Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E Tests] Disable default HTTPS scheme when creating a new connection #3452

Merged
merged 1 commit into from
May 13, 2024

Conversation

jsolovjo
Copy link
Contributor

@jsolovjo jsolovjo commented May 13, 2024

The changes introduced in hawtio/hawtio-next#930 cause E2E tests failures.

It happened due to default HTPPS scheme when a new connection is created.

The fix for E2E tests is to switch from default HTTPS to HTTP scheme when creating a new connection.

Copy link
Member

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Test Results

  4 files  ±0    4 suites  ±0   14m 24s ⏱️ +4s
 65 tests ±0   64 ✅ ±0   1 💤 ±0  0 ❌ ±0 
264 runs  ±0  254 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit 85685d6. ± Comparison against base commit 758fdb9.

@hawtio-ci
Copy link

hawtio-ci bot commented May 13, 2024

Test results

Run attempt: 1557
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-17-firefox 66 64 2 0 0 210.889
results-quarkus-21-firefox 66 64 2 0 0 219.496
results-springboot-17-firefox 66 63 3 0 0 219.406
results-springboot-21-firefox 66 63 3 0 0 214.296

@mmuzikar mmuzikar merged commit df63602 into hawtio:4.x May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants