Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hawtio-system): try to authenticate requests before redirecting to login #2701

Merged
merged 1 commit into from Sep 22, 2021
Merged

feat(hawtio-system): try to authenticate requests before redirecting to login #2701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 22 additions & 3 deletions hawtio-system/src/main/java/io/hawt/web/auth/LoginRedirectFilter.java
View file
Open in desktop
Expand Up @@ -13,6 +13,9 @@
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;

import io.hawt.system.AuthHelpers;
import io.hawt.system.AuthenticateResult;
import io.hawt.system.Authenticator;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -23,6 +26,7 @@ public class LoginRedirectFilter implements Filter {

private static final transient Logger LOG = LoggerFactory.getLogger(LoginRedirectFilter.class);

private int timeout;
private AuthenticationConfiguration authConfiguration;

private final String[] unsecuredPaths;
Expand All @@ -40,6 +44,8 @@ public LoginRedirectFilter(String[] unsecuredPaths) {
@Override
public void init(FilterConfig filterConfig) throws ServletException {
authConfiguration = AuthenticationConfiguration.getConfiguration(filterConfig.getServletContext());
timeout = AuthSessionHelpers.getSessionTimeout(filterConfig.getServletContext());
LOG.info("Hawtio loginRedirectFilter is using {} sec. HttpSession timeout", timeout);
}

@Override
Expand All @@ -51,19 +57,32 @@ public void doFilter(final ServletRequest request, final ServletResponse respons
HttpSession session = httpRequest.getSession(false);
String path = httpRequest.getServletPath();

if (isRedirectRequired(session, path)) {
if (isRedirectRequired(session, path, httpRequest)) {
redirector.doRedirect(httpRequest, httpResponse, AuthenticationConfiguration.LOGIN_URL);
} else {
chain.doFilter(request, response);
}
}

private boolean isRedirectRequired(HttpSession session, String path) {
private boolean isRedirectRequired(HttpSession session, String path, HttpServletRequest request) {
return authConfiguration.isEnabled()
&& !authConfiguration.isKeycloakEnabled()
&& !AuthSessionHelpers.isSpringSecurityEnabled()
&& !AuthSessionHelpers.isAuthenticated(session)
&& isSecuredPath(path);
&& isSecuredPath(path)
&& !tryAuthenticateRequest(request, session);
}

boolean tryAuthenticateRequest(HttpServletRequest request, HttpSession session) {
AuthenticateResult result = new Authenticator(request, authConfiguration).authenticate(
subject -> {
String username = AuthHelpers.getUsername(subject);
LOG.info("Logging in user: {}", username);
AuthSessionHelpers.setup(session != null ? session :
request.getSession(true), subject, username, timeout);
});

return result == AuthenticateResult.AUTHORIZED;
}

boolean isSecuredPath(String path) {
Expand Down