Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jekyll and the building process #93

Closed
wants to merge 1 commit into from

Conversation

napoly
Copy link
Contributor

@napoly napoly commented Apr 15, 2023

Upgrading Jekyll to 3.9.3 and Ubuntu to latest (22.04). Had to drop Ruby 2.6 support as running it backward compatible would require downgrading some of the dependencies. I assume the server is running already ruby 2.7 and higher.

@napoly napoly force-pushed the build_ubuntu_update branch 3 times, most recently from a696523 to cc54986 Compare April 15, 2023 18:22
@napoly napoly changed the title update Ubuntu build version to avoid deprecations wip: update Ubuntu build version to avoid deprecations Apr 15, 2023
@napoly napoly force-pushed the build_ubuntu_update branch 4 times, most recently from 4c64465 to 915fb80 Compare April 15, 2023 19:13
@napoly napoly changed the title wip: update Ubuntu build version to avoid deprecations Update Jekyll and the whole building process. Apr 15, 2023
@napoly napoly changed the title Update Jekyll and the whole building process. Update Jekyll and the building process Apr 15, 2023
@woodser
Copy link
Contributor

woodser commented Apr 15, 2023

Maybe it looks ok to @erciccione?

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Specifying webrick as a dependency shouldn't be necessary anymore.

@napoly
Copy link
Contributor Author

napoly commented Apr 17, 2023

Seems it has to be there for Ruby 3.x and higher as written in docs:

If you are using Ruby version 3.0.0 or higher, step 5 may fail. You may fix it by adding webrick to your dependencies: bundle add webrick

.. and fails on my localhost:
/var/lib/gems/3.0.0/gems/jekyll-3.9.3/lib/jekyll/commands/serve/servlet.rb:3:in `require': cannot load such file -- webrick (LoadError)

But there is another major version of Jekyll 4.x and they have added this dependency directly there at version 4.3.0. But upgrading directly to 4.3.2 version as of today would require to drop https://rubygems.org/gems/github-pages as the latest version 228 requires Jekyll 3.9.3.

So this PR is more about passing the build. Updating pipelines. Than having the newest Jekyll up and running.

@napoly napoly closed this Apr 23, 2023
@napoly napoly deleted the build_ubuntu_update branch April 23, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants