Improve error handling for missing Provider configurations #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtmm
force-pushed
the
non-existent-provider-errors
branch
from
ec3d895
to
7845880
Compare
fghaas
reviewed
Apr 15, 2024
| @@ -66,6 +66,9 @@ def init(name): | |||
| return OpenstackProvider(name, config, sleep_seconds) | |||
| elif provider_type == "gcloud": | |||
| return GcloudProvider(name, config, sleep_seconds) | |||
| else: | |||
There was a problem hiding this comment.
I think it's suboptimal that we end up with the same exception type with the same message in two different code paths, as it complicates troubleshooting. Thoughts?
There was a problem hiding this comment.
Hmm, perhaps yes. I updated the error message now.
Throw a ProviderException when a provider configuration is missing but the Provider is linked to an excisting Stack.
mrtmm
force-pushed
the
non-existent-provider-errors
branch
from
7845880
to
acd0d3e
Compare
fghaas
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw a ProviderException when a provider configuration is missing but the Provider is linked to an existing Stack.