Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nix CI, probably #3388

Merged
merged 2 commits into from Dec 8, 2022
Merged

Fix Nix CI, probably #3388

merged 2 commits into from Dec 8, 2022

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Dec 7, 2022

Seems that we have a weird nix version override from 2021 with the introduction
of flakes. No way that's load bearing, so let's delete it and see what happens.

Weird Nix version override added in #1827

Fixes #3387

Report here suggests that other people with overridden Nix versions are having
the same CI issues: cachix/install-nix-action#148

@lf-
Copy link
Contributor Author

lf- commented Dec 7, 2022

Confirmed, it gets past the broken step.

@fendor
Copy link
Collaborator

fendor commented Dec 8, 2022

Nice, ready for merge?

@michaelpj
Copy link
Collaborator

@lf- we appreciate your work! Are you interested in helping to keep this working in future? If so, add yourself to CODEOWNERS and I'll give you write access :)

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Dec 8, 2022
@mergify mergify bot merged commit 5cc2155 into haskell:master Dec 8, 2022
@lf-
Copy link
Contributor Author

lf- commented Dec 8, 2022

@lf- we appreciate your work! Are you interested in helping to keep this working in future? If so, add yourself to CODEOWNERS and I'll give you write access :)

Thanks! I am not sure if fixing Nix stuff is the best thing for my health given how much of it I do at work. I'll pass for now, but I may continue occasionally fixing my blockers.

@michaelpj
Copy link
Collaborator

No worries, thanks again!

blerner pushed a commit to CodeGrade/hourglass that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plausible cause of recent Nix CI failures
3 participants