Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESLint npm packages (major) #4284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 6, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) 8.57.0 -> 9.4.0 age adoption passing confidence
eslint-plugin-unicorn 51.0.1 -> 53.0.0 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.4.0

Compare Source

v9.3.0

Compare Source

v9.2.0

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.0

Compare Source

sindresorhus/eslint-plugin-unicorn (eslint-plugin-unicorn)

v53.0.0

Compare Source

New rules
Breaking
Meta
Improvements
  • Support ESLint 9 (#​2250) 598f57b
  • no-array-method-this-argument: Check Array.fromAsync() (#​2330) 99489b9
  • prefer-number-properties: Add checkNaN option (#​2315) d30de50
  • template-indent: Support member expression paths in tags and functions (#​2346) aabcf1d
  • prefer-number-properties: Don't require by default for Infinity/-Infinity to be written as Number.POSITIVE_INFINITY/Number.NEGATIVE_INFINITY (#​2312) e0dfed2
  • escape-case: Ignore String.raw (#​2342) 45bd444
  • no-hex-escape: Ignore String.raw (#​2343) cc02a7f
  • prefer-dom-node-dataset: Ignore awaited getAttribute call (#​2334) 45f23d5
  • prevent-abbreviations: Support non-ASCII filenames (#​2308) 28762c8
  • throw-new-error: Check all call expressions instead of just argument of ThrowStatement (#​2332) 1626852

v52.0.0

Compare Source

New rules
Improvements
  • filename-case: Add option for multiple file extensions (#​2186) 4594020
  • import-style: Support node: protocol (#​2297) c28a086
  • prefer-array-find: Check array.filter().at(0) (#​2284) e6074fe
  • prefer-prototype-methods: Check Object.prototype methods from globalThis (#​2286) 1792d33
  • no-array-callback-reference: Check logical expressions and check ternaries deeply (#​2289) 231529a
Fixes

Configuration

📅 Schedule: Branch creation - "before 4am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot enabled auto-merge April 6, 2024 19:25
renovate-approve[bot]
renovate-approve bot previously approved these changes Apr 6, 2024
renovate-approve[bot]
renovate-approve bot previously approved these changes Apr 8, 2024
@renovate renovate bot changed the title Update npm package eslint-plugin-unicorn to v52 Update ESLint npm packages (major) Apr 8, 2024
@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/blocks Relates to first-party blocks (area) area/apps > hash.dev Affects the `hash.dev` developer site (app) type/eng > frontend Owned by the @frontend team area/tests New or updated tests area/tests > integration New or updated integration tests area/tests > playwright New or updated Playwright tests area/apps > hash-realtime area/apps > hash-search-loader area/apps labels Apr 8, 2024
@vilkinsons
Copy link
Member

To be addressed alongside #4232

renovate-approve[bot]
renovate-approve bot previously approved these changes May 20, 2024
renovate-approve[bot]
renovate-approve bot previously approved these changes May 24, 2024
renovate-approve[bot]
renovate-approve bot previously approved these changes May 26, 2024
renovate-approve[bot]
renovate-approve bot previously approved these changes May 27, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Benchmark results

@rust/graph-benches – Integrations

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$1.55 \mathrm{s} \pm 4.10 \mathrm{ms}\left({\color{red}473 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$52.4 \mathrm{ms} \pm 359 \mathrm{μs}\left({\color{red}64.5 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$21.2 \mathrm{ms} \pm 83.5 \mathrm{μs}\left({\color{gray}-0.075 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$71.4 \mathrm{ms} \pm 474 \mathrm{μs}\left({\color{gray}-4.787 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$25.4 \mathrm{ms} \pm 158 \mathrm{μs}\left({\color{gray}0.438 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$17.1 \mathrm{ms} \pm 212 \mathrm{μs}\left({\color{gray}4.89 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.3 \mathrm{ms} \pm 166 \mathrm{μs}\left({\color{gray}-2.721 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.8 \mathrm{ms} \pm 154 \mathrm{μs}\left({\color{gray}2.29 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$15.3 \mathrm{ms} \pm 196 \mathrm{μs}\left({\color{lightgreen}-9.154 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.5 \mathrm{ms} \pm 163 \mathrm{μs}\left({\color{gray}-0.473 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$17.6 \mathrm{ms} \pm 211 \mathrm{μs}\left({\color{gray}-1.780 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.6 \mathrm{ms} \pm 205 \mathrm{μs}\left({\color{gray}-2.988 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$15.7 \mathrm{ms} \pm 159 \mathrm{μs}\left({\color{lightgreen}-24.899 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.1 \mathrm{ms} \pm 180 \mathrm{μs}\left({\color{gray}0.592 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$1.98 \mathrm{s} \pm 9.60 \mathrm{ms}\left({\color{gray}-2.505 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$1.05 \mathrm{s} \pm 5.42 \mathrm{ms}\left({\color{gray}-2.770 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$1.04 \mathrm{s} \pm 9.92 \mathrm{ms}\left({\color{gray}-3.120 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$96.8 \mathrm{ms} \pm 531 \mathrm{μs}\left({\color{gray}0.106 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$418 \mathrm{ms} \pm 1.59 \mathrm{ms}\left({\color{gray}-1.797 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$60.9 \mathrm{ms} \pm 192 \mathrm{μs}\left({\color{gray}0.056 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$2.84 \mathrm{s} \pm 12.0 \mathrm{ms}\left({\color{gray}-0.550 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$970 \mathrm{ms} \pm 5.36 \mathrm{ms}\left({\color{gray}-0.695 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$956 \mathrm{ms} \pm 2.71 \mathrm{ms}\left({\color{gray}-2.856 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$40.5 \mathrm{ms} \pm 246 \mathrm{μs}\left({\color{gray}-0.704 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$352 \mathrm{ms} \pm 1.44 \mathrm{ms}\left({\color{gray}-3.236 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$36.7 \mathrm{ms} \pm 243 \mathrm{μs}\left({\color{gray}-3.756 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.41 \mathrm{ms} \pm 8.10 \mathrm{μs}\left({\color{gray}0.553 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1000 entities $$3.30 \mathrm{ms} \pm 13.5 \mathrm{μs}\left({\color{gray}-0.482 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.57 \mathrm{ms} \pm 8.19 \mathrm{μs}\left({\color{gray}0.507 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.43 \mathrm{ms} \pm 9.41 \mathrm{μs}\left({\color{gray}-0.643 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.5 \mathrm{ms} \pm 126 \mathrm{μs}\left({\color{gray}1.22 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.45 \mathrm{ms} \pm 10.2 \mathrm{μs}\left({\color{gray}0.044 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$4.65 \mathrm{ms} \pm 23.8 \mathrm{μs}\left({\color{gray}4.51 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.70 \mathrm{ms} \pm 10.5 \mathrm{μs}\left({\color{gray}2.73 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.49 \mathrm{ms} \pm 11.9 \mathrm{μs}\left({\color{gray}-0.118 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.15 \mathrm{ms} \pm 26.0 \mathrm{μs}\left({\color{gray}-1.280 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$2.53 \mathrm{ms} \pm 13.3 \mathrm{μs}\left({\color{gray}0.144 \mathrm{\%}}\right) $$ Flame Graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash.dev Affects the `hash.dev` developer site (app) area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps > hash-realtime area/apps > hash-search-loader area/apps area/blocks Relates to first-party blocks (area) area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests > integration New or updated integration tests area/tests > playwright New or updated Playwright tests area/tests New or updated tests priority/2 medium Medium priority: needs to be done type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team
Development

Successfully merging this pull request may close these issues.

None yet

1 participant