Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-34: deer: implement Content IR #2434

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

GEN-34: deer: implement Content IR #2434

wants to merge 15 commits into from

Conversation

indietyp
Copy link
Member

@indietyp indietyp commented Apr 17, 2023

🌟 What is the purpose of this PR?

This implements Content and related Deserializers, which is one of the last steps needed before we can start on the derive macro.

🚫 Blocked by

🚀 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • does not modify any publishable blocks or libraries, or modifications do not need publishing
  • I am unsure / need advice

@indietyp indietyp added the state/blocked This pull request is currently blocked label Apr 17, 2023
@github-actions github-actions bot added the area/libs > deer Affects the `deer` crate (library) label Apr 17, 2023
libs/deer/src/content.rs Fixed Show fixed Hide fixed
libs/deer/src/content.rs Fixed Show fixed Hide fixed
libs/deer/src/content.rs Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cee1a1b) 52.75% compared to head (56975b2) 56.41%.
Report is 1118 commits behind head on main.

❗ Current head 56975b2 differs from pull request most recent head d3a81a6. Consider uploading reports for the commit d3a81a6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
+ Coverage   52.75%   56.41%   +3.65%     
==========================================
  Files         331      341      +10     
  Lines       27555    26287    -1268     
  Branches      420      421       +1     
==========================================
+ Hits        14538    14829     +291     
+ Misses      13015    11453    -1562     
- Partials        2        5       +3     
Flag Coverage Δ
backend-integration-tests 3.66% <ø> (-3.69%) ⬇️
unit-tests 1.49% <ø> (+1.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@indietyp indietyp removed the state/blocked This pull request is currently blocked label May 3, 2023
libs/deer/src/content.rs Fixed Show fixed Hide fixed
libs/deer/src/content.rs Fixed Show fixed Hide fixed
@vilkinsons vilkinsons changed the title deer: implement Content IR deer: implement Content IR May 3, 2023
@indietyp indietyp marked this pull request as ready for review June 7, 2023 16:42
@indietyp indietyp requested a review from a team as a code owner June 7, 2023 16:42
@indietyp indietyp marked this pull request as draft June 7, 2023 16:42
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@linear
Copy link

linear bot commented Aug 8, 2023

GEN-34

@TimDiekmann TimDiekmann removed the request for review from a team September 2, 2023 16:51
@vilkinsons vilkinsons added the priority/3 low Lower priority: nice-to-have label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > deer Affects the `deer` crate (library) priority/3 low Lower priority: nice-to-have
Development

Successfully merging this pull request may close these issues.

None yet

2 participants