Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-35: error-stack implement serde hooks #1558

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

GEN-35: error-stack implement serde hooks #1558

wants to merge 55 commits into from

Commits on Nov 30, 2022

  1. feat: convert serde to module

    @indietyp
    indietyp committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    2885f9b View commit details
    Browse the repository at this point in the history

  2. feat: start serialize hook

    @indietyp
    indietyp committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    fb4520b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. feat: continue work on hooks

    @indietyp
    indietyp committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    50d9993 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. feat: serde static and dynamic hooks

    @indietyp
    indietyp committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    f6b721e View commit details
    Browse the repository at this point in the history

  2. feat: serde lifetime fun

    @indietyp
    indietyp committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    6b82a51 View commit details
    Browse the repository at this point in the history

  3. fix: compile errors

    @indietyp
    indietyp committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    a3167a1 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Merge branch 'main' into bm/es/serde-hooks

    @indietyp
    indietyp committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    b755a0c View commit details
    Browse the repository at this point in the history

  2. feat: dispatch closure through fn

    @indietyp
    indietyp committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5725e59 View commit details
    Browse the repository at this point in the history

  3. feat: use traits to constraint lifetime of U 

    (WIP)
    @indietyp
    indietyp committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    724a0a0 View commit details
    Browse the repository at this point in the history

  4. feat: use traits to constraint lifetime of U 

    (WIP)
    @indietyp
    indietyp committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    3a6f360 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. feat: it works?

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    5c44c7d View commit details
    Browse the repository at this point in the history

  2. feat: install custom serde hook

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    4ae6bd5 View commit details
    Browse the repository at this point in the history

  3. feat: integration test

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    e321ff5 View commit details
    Browse the repository at this point in the history

  4. feat: integration test

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    3b85638 View commit details
    Browse the repository at this point in the history

  5. feat: introduce hooks into serializer

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    9f5d32b View commit details
    Browse the repository at this point in the history

  6. fix: WIP 

    (currently mutable borrow of the `HookContext` provides some challenges)
    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    bdea88b View commit details
    Browse the repository at this point in the history

  7. fix: reference shenanigans

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    4ab9d0b View commit details
    Browse the repository at this point in the history

  8. fix: more references!

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    ddac2d2 View commit details
    Browse the repository at this point in the history

  9. feat: cfg hook capabilities

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    05baaaf View commit details
    Browse the repository at this point in the history

  10. fix: lint

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    1c4871b View commit details
    Browse the repository at this point in the history

  11. test: custom hook snapshot

    @indietyp
    indietyp committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    1c05422 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. feat: built-in hooks

    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    77f2008 View commit details
    Browse the repository at this point in the history

  2. feat: unify helpers of test_debug and test_serialize

    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    91ced98 View commit details
    Browse the repository at this point in the history

  3. fix: compilation errors

    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    845fff8 View commit details
    Browse the repository at this point in the history

  4. chore: update snapshots

    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    0abe3db View commit details
    Browse the repository at this point in the history

  5. fix: lint

    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    1d7221d View commit details
    Browse the repository at this point in the history

  6. chore: update snapshots

    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    38ffd86 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into bm/es/serde-hooks

    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    ceab0d2 View commit details
    Browse the repository at this point in the history

  8. chore: snapshots are now json 

    IT’S JSON TIME!
    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    1d976d0 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'bm/es/serde-hooks' of github.com:hashintel/hash into bm… 

    …/es/serde-hooks
    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    aaca87f View commit details
    Browse the repository at this point in the history

  10. fix: import visibility for Serde

    @indietyp
    indietyp committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    b37c9a4 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2022

  1. feat: nightly only test for closures

    @indietyp
    indietyp committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    81253a2 View commit details
    Browse the repository at this point in the history

  2. chore: remove incorrect comment

    @indietyp
    indietyp committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    43c600b View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. feat: serde::Hooks-> SerdeHooks, fmt::Hooks -> FmtHooks

    @indietyp
    indietyp committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    83edbf2 View commit details
    Browse the repository at this point in the history

  2. feat: DynamicFn -> SerializeFn

    @indietyp
    indietyp committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    0941b84 View commit details
    Browse the repository at this point in the history

  3. chore: update snapshots

    @indietyp
    indietyp committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    7b39856 View commit details
    Browse the repository at this point in the history

  4. feat: backtrace builtin hook

    @indietyp
    indietyp committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    efc3db4 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into bm/es/serde-hooks

    @indietyp
    indietyp committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    3f57310 View commit details
    Browse the repository at this point in the history

  6. chore: remove unneeded lifetime

    @indietyp
    indietyp committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    8c30be3 View commit details
    Browse the repository at this point in the history

  7. chore: for now allow missing docs on undocumented methods 

    (upcoming PR will add them)
    @indietyp
    indietyp committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    35fdfe2 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'bm/es/serde-hooks' of github.com:hashintel/hash into bm… 

    …/es/serde-hooks
    @indietyp
    indietyp committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    28780d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. fix: lint

    @indietyp
    indietyp committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    2ccccfe View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Merge remote-tracking branch 'origin/main' into bm/es/serde-hooks 

    # Conflicts:
#	packages/libs/error-stack/src/fmt/mod.rs
#	packages/libs/error-stack/tests/snapshots/test_debug__full__alt.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__complex.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__hook.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__hook_context.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__hook_decr.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__hook_for_context.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__hook_incr.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__hook_multiple.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__hook_provider.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__linear.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__linear_ext.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__multiline.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__multiline_context.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__norm.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__sources.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__sources_transparent.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested@backtrace-pretty-print-hooks.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested@pretty-print.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested@spantrace-backtrace-pretty-print-hooks.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested@spantrace-pretty-print-hooks.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@backtrace-pretty-print-hooks.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@pretty-print.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@spantrace-backtrace-pretty-print-hooks.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@spantrace-pretty-print-hooks.snap
    @indietyp
    indietyp committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    f4c30af View commit details
    Browse the repository at this point in the history

  2. fix: merge conflicts

    @indietyp
    indietyp committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    491c94b View commit details
    Browse the repository at this point in the history

  3. chore: update snapshots

    @indietyp
    indietyp committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    c528da9 View commit details
    Browse the repository at this point in the history

  4. test: remove backtrace for serialize tests

    @indietyp
    indietyp committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    b44832e View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. feat: disable backtrace for serde

    @indietyp
    indietyp committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    cb766d0 View commit details
    Browse the repository at this point in the history

  2. chore: update stable snaps

    @indietyp
    indietyp committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    47364dd View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Merge remote-tracking branch 'origin/main' into bm/es/serde-hooks 

    # Conflicts:
#	libs/error-stack/Cargo.toml
#	libs/error-stack/Makefile.toml
#	libs/error-stack/src/fmt.rs
#	libs/error-stack/src/fmt/hook.rs
#	libs/error-stack/src/serde.rs
#	libs/error-stack/tests/common.rs
#	libs/error-stack/tests/snapshots/test_debug__full__alt.snap
#	libs/error-stack/tests/snapshots/test_debug__full__color_mode_color.snap
#	libs/error-stack/tests/snapshots/test_debug__full__hook.snap
#	libs/error-stack/tests/snapshots/test_debug__full__hook_decr.snap
#	libs/error-stack/tests/snapshots/test_debug__full__hook_incr.snap
#	libs/error-stack/tests/snapshots/test_debug__full__hook_multiple.snap
#	libs/error-stack/tests/snapshots/test_debug__full__hook_provider.snap
#	libs/error-stack/tests/snapshots/test_debug__full__multiline.snap
#	libs/error-stack/tests/snapshots/test_debug__full__multiline_context.snap
#	libs/error-stack/tests/snapshots/test_debug__full__norm.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested@backtrace-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested@backtrace-pretty-print-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested@hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested@pretty-print-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested@spantrace-backtrace-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested@spantrace-backtrace-pretty-print-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested@spantrace-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested@spantrace-pretty-print-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@backtrace-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@backtrace-pretty-print-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@pretty-print-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@spantrace-backtrace-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@spantrace-backtrace-pretty-print-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@spantrace-hooks.snap
#	libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@spantrace-pretty-print-hooks.snap
#	libs/error-stack/tests/snapshots/test_serialize__attachment.snap
#	libs/error-stack/tests/snapshots/test_serialize__context.snap
#	libs/error-stack/tests/snapshots/test_serialize__full__attachment.snap
#	libs/error-stack/tests/snapshots/test_serialize__full__context.snap
#	libs/error-stack/tests/snapshots/test_serialize__full__hook_custom.snap
#	libs/error-stack/tests/snapshots/test_serialize__full__hook_custom_owned.snap
#	libs/error-stack/tests/snapshots/test_serialize__full__multiple_sources.snap
#	libs/error-stack/tests/snapshots/test_serialize__full__multiple_sources_at_root.snap
#	libs/error-stack/tests/snapshots/test_serialize__multiple_sources.snap
#	libs/error-stack/tests/snapshots/test_serialize__multiple_sources_at_root.snap
#	libs/error-stack/tests/snapshots/test_serialize__sources_nested.snap
#	libs/error-stack/tests/snapshots/test_serialize__sources_nested@backtrace-hooks.snap
#	libs/error-stack/tests/snapshots/test_serialize__sources_nested@hooks.snap
#	libs/error-stack/tests/snapshots/test_serialize__sources_nested@spantrace-backtrace-hooks.snap
#	libs/error-stack/tests/snapshots/test_serialize__sources_nested@spantrace-hooks.snap
#	libs/error-stack/tests/test_debug.rs
#	packages/libs/error-stack/tests/common.rs
#	packages/libs/error-stack/tests/common/mod.rs
#	packages/libs/error-stack/tests/snapshots/test_debug__full__complex.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__hook_multiple.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__linear.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__linear_ext.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__sources.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__full__sources_transparent.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested@pretty-print.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate.snap
#	packages/libs/error-stack/tests/snapshots/test_debug__sources_nested_alternate@pretty-print.snap
    @indietyp
    indietyp committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    14506e0 View commit details
    Browse the repository at this point in the history

  2. fix: merge conflicts

    @indietyp
    indietyp committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    8a7b3fe View commit details
    Browse the repository at this point in the history

  3. fix: merge conflicts (II)

    @indietyp
    indietyp committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    1b4db94 View commit details
    Browse the repository at this point in the history

  4. fix: merge conflicts (III)

    @indietyp
    indietyp committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    cce1439 View commit details
    Browse the repository at this point in the history

  5. fix: merge conflicts (IV)

    @indietyp
    indietyp committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    58b90e8 View commit details
    Browse the repository at this point in the history

  6. feat: start with serde config

    @indietyp
    indietyp committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    64077b4 View commit details
    Browse the repository at this point in the history

  7. feat: start with serde config

    @indietyp
    indietyp committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    d9b1f78 View commit details
    Browse the repository at this point in the history