fixed issue in translating nested hash with multiple string keys #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [#518](https://github.com/hashie/hashie/pull/518): fixed issue in translating nested hash with multiple string keys - [@jitendra1998](https://github.com/jitendra1998).Generated by 🚫 Danger |
|
Awesome.
|
sure will create a new pr for fixing failed integration spec |
|
Thanks for #520. Rebase? |
dblock
reviewed
Apr 12, 2020
| @@ -28,7 +28,7 @@ scheme are considered to be bugs. | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| * Your contribution here. | |||
dblock
reviewed
Apr 12, 2020
| @@ -28,7 +28,7 @@ scheme are considered to be bugs. | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| * Your contribution here. | |||
| * [#518](https://github.com/hashie/hashie/pull/518): fixed issue in translating nested hash with multiple string keys - [@jitendra1998](https://github.com/jitendra1998). | |||
There was a problem hiding this comment.
Needs to start with a capital Fixed.
dblock
reviewed
Apr 12, 2020
| name = name.to_s | ||
| !!properties.find { |property| property.to_s == name } | ||
| if name.is_a? ::Array | ||
| name.all? { |att| !!properties.find { |property| property.to_s == att.to_s } } |
There was a problem hiding this comment.
Does name require a translation again in the Array case? Should come up with a nested test case with translations at all levels.
If so, then name.all? { |att | property?(att) }?
|
Want to try and finish this @jitendra1998 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #514 in this pr