Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil valued keys are no longer being written out in v3.6.0 #470

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Nil valued keys are no longer being written out in v3.6.0 #470

wants to merge 2 commits into from

Commits on Nov 17, 2019

  1. Add a failing test that demonstrates that nil valued keys are no long… 

    …er being written out
    @hlascelles @michaelherold
    hlascelles authored and michaelherold committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    d25a995 View commit details
    Browse the repository at this point in the history

  2. Ensure we return nils for unset keys in Dash 

    In 0bd18ee, we stopped setting any `nil` values on the Dash in order to
prevent co-dependent properties from throwing errors. This is a problem
because it means that when you explicitly set `nil` as a value for
a property, it's not set on the underlying hash and you will not get it
back if you call `#to_h`.

By explicitly setting a nil value on the result of `#to_h` for unset
keys, we can avoid this issue and return what the called expects.
    @michaelherold
    michaelherold committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    d6718cc View commit details
    Browse the repository at this point in the history