Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new extension: Hashie::Extensions::Dash::PsychSerialization #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juozasg
Copy link

@juozasg juozasg commented Dec 11, 2014

Without custom encode_with and init_with methods YAML/Psych serialization will not work. Tested with Ruby 2.1.3

@dblock
Copy link
Member

dblock commented Dec 12, 2014

Is this really about Psych or something more generic? I believe encode_with and init_with are more general Ruby serialization properties, so likely the class shouldn't be called PsychSerialization, but maybe just Serialization or RubySerialization ... maybe you can dig up where those come from and come up with a better name?

This also needs a README and CHANGELOG update, please.

@dblock
Copy link
Member

dblock commented Dec 30, 2014

Bump @juozasg.

@maxlinc
Copy link
Contributor

maxlinc commented Jan 13, 2015

What is it that "will not work"?

@cheerfulstoic
Copy link

I think I've just run into this problem or something like it. I'm using a ActiveSupport::Cache::FileStore cache to store responses from the github_api gem which uses Hashie::Mash for it's body. On the first request it's fine because it returns the response object directly, but on subsequent requests where it returns the deserialized cache, the body is now just a Hash.

The ActiveSupport serialization format isn't the most readable, but I see a reference to bodyC:Hashie::Mash in there, so I think it's getting serialized correctly, but just not de-serialized

@michaelherold
Copy link
Member

Bump @juozasg

@cheerfulstoic Could you provide a reproducible example of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants