Disable rspec monkeypatching

hashie · Feb 5, 2015 · d03759f · d03759f · maxlinc · Mar 8, 2015
1 parent 3bfdc63
commit d03759f
Show file tree

Hide file tree

Showing 26 changed files with 43 additions and 41 deletions.
diff --git a/spec/hashie/clash_spec.rb b/spec/hashie/clash_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Clash do
+RSpec.describe Hashie::Clash do
   subject { Hashie::Clash.new }
 
   it 'is able to set an attribute via method_missing' do

diff --git a/spec/hashie/dash_spec.rb b/spec/hashie/dash_spec.rb
@@ -51,7 +51,7 @@ class DeferredWithSelfTest < Hashie::Dash
   property :updated_at, default: ->(test) { test.created_at }
 end
 
-describe DashTest do
+RSpec.describe DashTest do
   def property_required_error(property)
     [ArgumentError, "The property '#{property}' is required for #{subject.class.name}."]
   end
@@ -368,7 +368,7 @@ class DashMessageOptionWithoutRequiredTest < Hashie::Dash
   end
 end
 
-describe Hashie::Dash, 'inheritance' do
+RSpec.describe Hashie::Dash, 'inheritance' do
   before do
     @top = Class.new(Hashie::Dash)
     @middle = Class.new(@top)
@@ -414,7 +414,7 @@ class DashMessageOptionWithoutRequiredTest < Hashie::Dash
   end
 end
 
-describe SubclassedTest do
+RSpec.describe SubclassedTest do
   subject { SubclassedTest.new(first_name: 'Bob', last_name: 'McNob', email: 'bob@example.com') }
 
   describe '#count' do
@@ -441,7 +441,7 @@ class ConditionallyRequiredTest < Hashie::Dash
   property :password, required: -> { !username.nil? }, message: 'must be set, too.'
 end
 
-describe ConditionallyRequiredTest do
+RSpec.describe ConditionallyRequiredTest do
   it 'does not allow a conditionally required property to be set to nil if required' do
     expect { ConditionallyRequiredTest.new(username: 'bob.smith', password: nil) }.to raise_error(ArgumentError, "The property 'password' must be set, too.")
   end
@@ -460,7 +460,7 @@ class MixedPropertiesTest < Hashie::Dash
   property 'string'
 end
 
-describe MixedPropertiesTest do
+RSpec.describe MixedPropertiesTest do
   subject { MixedPropertiesTest.new('string' => 'string', symbol: 'symbol') }
 
   it { should respond_to('string') }
@@ -500,7 +500,7 @@ class MixedPropertiesTest < Hashie::Dash
   end
 end
 
-context 'Dynamic Dash Class' do
+RSpec.context 'Dynamic Dash Class' do
   it 'define property' do
     klass       = Class.new(Hashie::Dash)
     my_property = 'my_property'

diff --git a/spec/hashie/extensions/autoload_spec.rb b/spec/hashie/extensions/autoload_spec.rb
@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'hashie'
 
-describe Hashie::Extensions do
+RSpec.describe Hashie::Extensions do
   describe 'autloads constants' do
     it { is_expected.to be_const_defined(:MethodAccess) }
     it { is_expected.to be_const_defined(:Coercion) }

diff --git a/spec/hashie/extensions/coercion_spec.rb b/spec/hashie/extensions/coercion_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::Coercion do
+RSpec.describe Hashie::Extensions::Coercion do
   class NotInitializable
     private_class_method :new
   end

diff --git a/spec/hashie/extensions/dash/indifferent_access_spec.rb b/spec/hashie/extensions/dash/indifferent_access_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::Dash::IndifferentAccess do
+RSpec.describe Hashie::Extensions::Dash::IndifferentAccess do
   class TrashWithIndifferentAccess < Hashie::Trash
     include Hashie::Extensions::Dash::IndifferentAccess
     property :per_page, transform_with: ->(v) { v.to_i }

diff --git a/spec/hashie/extensions/deep_fetch_spec.rb b/spec/hashie/extensions/deep_fetch_spec.rb
@@ -2,7 +2,7 @@
 
 module Hashie
   module Extensions
-    describe DeepFetch do
+    RSpec.describe DeepFetch do
       subject { Class.new(Hash) { include Hashie::Extensions::DeepFetch } }
       let(:hash) do
         {

diff --git a/spec/hashie/extensions/deep_find_spec.rb b/spec/hashie/extensions/deep_find_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::DeepFind do
+RSpec.describe Hashie::Extensions::DeepFind do
   subject { Class.new(Hash) { include Hashie::Extensions::DeepFind } }
   let(:hash) do
     {

diff --git a/spec/hashie/extensions/deep_locate_spec.rb b/spec/hashie/extensions/deep_locate_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::DeepLocate do
+RSpec.describe Hashie::Extensions::DeepLocate do
   let(:hash) do
     {
       from: 0,

diff --git a/spec/hashie/extensions/deep_merge_spec.rb b/spec/hashie/extensions/deep_merge_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::DeepMerge do
+RSpec.describe Hashie::Extensions::DeepMerge do
   class DeepMergeHash < Hash
     include Hashie::Extensions::DeepMerge
   end

diff --git a/spec/hashie/extensions/ignore_undeclared_spec.rb b/spec/hashie/extensions/ignore_undeclared_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::IgnoreUndeclared do
+RSpec.describe Hashie::Extensions::IgnoreUndeclared do
   context 'included in Trash' do
     class ForgivingTrash < Hashie::Trash
       include Hashie::Extensions::IgnoreUndeclared

diff --git a/spec/hashie/extensions/indifferent_access_spec.rb b/spec/hashie/extensions/indifferent_access_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::IndifferentAccess do
+RSpec.describe Hashie::Extensions::IndifferentAccess do
   class IndifferentHashWithMergeInitializer < Hash
     include Hashie::Extensions::MergeInitializer
     include Hashie::Extensions::IndifferentAccess

diff --git a/spec/hashie/extensions/indifferent_access_with_rails_hwia_spec.rb b/spec/hashie/extensions/indifferent_access_with_rails_hwia_spec.rb
@@ -4,7 +4,7 @@
 require 'spec_helper'
 require 'active_support/hash_with_indifferent_access'
 
-describe Hashie::Extensions::IndifferentAccess do
+RSpec.describe Hashie::Extensions::IndifferentAccess do
   class IndifferentHashWithMergeInitializer < Hash
     include Hashie::Extensions::MergeInitializer
     include Hashie::Extensions::IndifferentAccess

diff --git a/spec/hashie/extensions/key_conversion_spec.rb b/spec/hashie/extensions/key_conversion_spec.rb
@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'support/module_context'
 
-describe Hashie::Extensions::KeyConversion do
+RSpec.describe Hashie::Extensions::KeyConversion do
   include_context 'included hash module'
 
   it { should respond_to(:stringify_keys) }

diff --git a/spec/hashie/extensions/mash/safe_assignment_spec.rb b/spec/hashie/extensions/mash/safe_assignment_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::Mash::SafeAssignment do
+RSpec.describe Hashie::Extensions::Mash::SafeAssignment do
   class MashWithSafeAssignment < Hashie::Mash
     include Hashie::Extensions::Mash::SafeAssignment
   end

diff --git a/spec/hashie/extensions/merge_initializer_spec.rb b/spec/hashie/extensions/merge_initializer_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::MergeInitializer do
+RSpec.describe Hashie::Extensions::MergeInitializer do
   class MergeInitializerHash < Hash
     include Hashie::Extensions::MergeInitializer
   end

diff --git a/spec/hashie/extensions/method_access_spec.rb b/spec/hashie/extensions/method_access_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::MethodReader do
+RSpec.describe Hashie::Extensions::MethodReader do
   class ReaderHash < Hash
     include Hashie::Extensions::MethodReader
 
@@ -52,7 +52,7 @@ def initialize(hash = {})
   end
 end
 
-describe Hashie::Extensions::MethodWriter do
+RSpec.describe Hashie::Extensions::MethodWriter do
   class WriterHash < Hash
     include Hashie::Extensions::MethodWriter
   end
@@ -80,7 +80,7 @@ class WriterHash < Hash
   end
 end
 
-describe Hashie::Extensions::MethodQuery do
+RSpec.describe Hashie::Extensions::MethodQuery do
   class QueryHash < Hash
     include Hashie::Extensions::MethodQuery
 
@@ -120,15 +120,15 @@ def initialize(hash = {})
   end
 end
 
-describe Hashie::Extensions::MethodAccess do
+RSpec.describe Hashie::Extensions::MethodAccess do
   it 'includes all of the other method mixins' do
     klass = Class.new(Hash)
     klass.send :include, Hashie::Extensions::MethodAccess
     expect((klass.ancestors & [Hashie::Extensions::MethodReader, Hashie::Extensions::MethodWriter, Hashie::Extensions::MethodQuery]).size).to eq 3
   end
 end
 
-describe Hashie::Extensions::MethodOverridingWriter do
+RSpec.describe Hashie::Extensions::MethodOverridingWriter do
   class OverridingHash < Hash
     include Hashie::Extensions::MethodOverridingWriter
   end
@@ -175,7 +175,7 @@ class OverridingHash < Hash
   end
 end
 
-describe Hashie::Extensions::MethodAccessWithOverride do
+RSpec.describe Hashie::Extensions::MethodAccessWithOverride do
   it 'includes all of the other method mixins' do
     klass = Class.new(Hash)
     klass.send :include, Hashie::Extensions::MethodAccessWithOverride

diff --git a/spec/hashie/extensions/stringify_keys_spec.rb b/spec/hashie/extensions/stringify_keys_spec.rb
@@ -9,7 +9,7 @@ def invoke(method)
   end
 end
 
-shared_examples 'stringify_keys!' do
+RSpec.shared_examples 'stringify_keys!' do
   it 'converts keys to strings' do
     object[:abc] = 'abc'
     object[123] = '123'
@@ -42,7 +42,7 @@ def invoke(method)
   end
 end
 
-shared_examples 'stringify_keys' do
+RSpec.shared_examples 'stringify_keys' do
   it 'converts keys to strings' do
     object[:abc] = 'def'
     copy = invoke :stringify_keys
@@ -57,7 +57,7 @@ def invoke(method)
   end
 end
 
-describe Hashie::Extensions::StringifyKeys do
+RSpec.describe Hashie::Extensions::StringifyKeys do
   include_context 'included hash module'
   let(:object) { subject }
 
@@ -82,7 +82,7 @@ def invoke(method)
   end
 end
 
-describe Hashie do
+RSpec.describe Hashie do
   let!(:dummy_class) do
     klass = Class.new(::Hash)
     klass.send :include, Hashie::Extensions::StringifyKeys

diff --git a/spec/hashie/extensions/symbolize_keys_spec.rb b/spec/hashie/extensions/symbolize_keys_spec.rb
@@ -9,7 +9,7 @@ def invoke(method)
   end
 end
 
-shared_examples 'symbolize_keys!' do
+RSpec.shared_examples 'symbolize_keys!' do
   it 'converts keys to symbols' do
     object['abc'] = 'abc'
     object['def'] = 'def'
@@ -42,7 +42,7 @@ def invoke(method)
   end
 end
 
-shared_examples 'symbolize_keys' do
+RSpec.shared_examples 'symbolize_keys' do
   it 'converts keys to symbols' do
     object['abc'] = 'def'
     copy = invoke :symbolize_keys
@@ -57,7 +57,7 @@ def invoke(method)
   end
 end
 
-describe Hashie::Extensions::SymbolizeKeys do
+RSpec.describe Hashie::Extensions::SymbolizeKeys do
   include_context 'included hash module'
   let(:object) { subject }
 
@@ -87,7 +87,7 @@ def invoke(method)
   end
 end
 
-describe Hashie do
+RSpec.describe Hashie do
   let!(:dummy_class) do
     klass = Class.new(::Hash)
     klass.send :include, Hashie::Extensions::StringifyKeys

diff --git a/spec/hashie/hash_spec.rb b/spec/hashie/hash_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hash do
+RSpec.describe Hash do
   it 'is convertible to a Hashie::Mash' do
     mash = Hashie::Hash[some: 'hash'].to_mash
     expect(mash.is_a?(Hashie::Mash)).to be_truthy

diff --git a/spec/hashie/mash_spec.rb b/spec/hashie/mash_spec.rb
@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'delegate'
 
-describe Hashie::Mash do
+RSpec.describe Hashie::Mash do
   subject { Hashie::Mash.new }
 
   it 'inherits from Hash' do

diff --git a/spec/hashie/parsers/yaml_erb_parser_spec.rb b/spec/hashie/parsers/yaml_erb_parser_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Extensions::Parsers::YamlErbParser do
+RSpec.describe Hashie::Extensions::Parsers::YamlErbParser do
   describe '.perform' do
     let(:config) do
       <<-EOF

diff --git a/spec/hashie/rash_spec.rb b/spec/hashie/rash_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Rash do
+RSpec.describe Hashie::Rash do
   subject do
     Hashie::Rash.new(
       /hello/ => 'hello',

diff --git a/spec/hashie/trash_spec.rb b/spec/hashie/trash_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie::Trash do
+RSpec.describe Hashie::Trash do
   class TrashTest < Hashie::Trash
     property :first_name, from: :firstName
   end

diff --git a/spec/hashie/version_spec.rb b/spec/hashie/version_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Hashie do
+RSpec.describe  do
   it 'has a version' do
     expect(Hashie::VERSION).not_to be_nil
   end

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -9,6 +9,8 @@
 require 'hashie'
 
 RSpec.configure do |config|
+  config.disable_monkey_patching!
+
   config.expect_with :rspec do |expect|
     expect.syntax = :expect
   end

diff --git a/spec/support/module_context.rb b/spec/support/module_context.rb
@@ -1,4 +1,4 @@
-shared_context 'included hash module' do
+RSpec.shared_context 'included hash module' do
   let!(:dummy_class) do
     klass = Class.new(::Hash)
     klass.send :include, described_class