Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

build(deps-dev): bump ua-parser-js from 0.7.24 to 1.0.2 in /ui #3879

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 15, 2022

Bumps ua-parser-js from 0.7.24 to 1.0.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team September 15, 2022 09:39
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 15, 2022
@github-actions github-actions bot added the ui label Sep 15, 2022
@jgwhite jgwhite added the pr/no-changelog No automatic changelog entry required for this pull request label Sep 15, 2022
@jgwhite
Copy link
Contributor

jgwhite commented Sep 15, 2022

@dependabot rebase

@jgwhite
Copy link
Contributor

jgwhite commented Sep 15, 2022

Seems like this package had a major security issue: faisalman/ua-parser-js#536

@jgwhite
Copy link
Contributor

jgwhite commented Sep 15, 2022

It seems in a pretty sad maintenance state. The changelog is meaningless. I can’t tell why they cut a 1.0.0 version. I wonder if we could just ditch this dependency?

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ui/ua-parser-js-1.0.2 branch from 23f6c00 to 793419c Compare September 15, 2022 13:34
@jgwhite
Copy link
Contributor

jgwhite commented Sep 15, 2022

We only use it in one place:

import { UAParser } from 'ua-parser-js';
export default class OnboardingInstallIndex extends Route {
redirect(): void {
let parser = new UAParser();
switch (parser.getResult().os.name) {

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.24 to 1.0.2.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Commits](faisalman/ua-parser-js@0.7.24...1.0.2)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 19, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ui/ua-parser-js-1.0.2 branch September 19, 2022 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file pr/no-changelog No automatic changelog entry required for this pull request ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant