This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
ui: upgrade ember from 3.24.4 to 3.24.5 #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwhite
added
ui
pr/no-changelog
|
whoops looks like the lint task failed |
Yup, my bad. See #2350 |
Includes the following bugfixes: - [#19685](emberjs/ember.js#19685) Fix memory leak with `RouterService` under Chrome - [#19683](emberjs/ember.js#19683) Ensure `super.willDestroy` is called correctly in `Router`'s `willDestroy`
jgwhite
force-pushed
the
ui/ember-3.24.5
branch
from
641560b
to
794b598
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the change?
The following memory leak bugfix sounds valuable to us:
RouterServiceunder ChromeHow do I test it?
cd ui && yarn start)