Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions/setup-node to v2 #897

Merged
merged 4 commits into from Jan 10, 2022
Merged

Update actions/setup-node to v2 #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1850b6
use actions/setup-node@v2 for test
dbanck Jan 10, 2022
953defd
use actions/setup-node@v2 for build
dbanck Jan 10, 2022
1ad5b09
use actions/setup-node@v2 for publish
dbanck Jan 10, 2022
720e3dc
simplify preview with actions/setup-node@v2
dbanck Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 4 additions & 12 deletions .github/workflows/build.yml
View file
Open in desktop
Expand Up @@ -12,21 +12,13 @@ jobs:
- name: checkout repo
uses: actions/checkout@v2

- name: Read NodeJS version
id: nodejs-version
run: |
content=`cat ./.nvmrc`
echo "::set-output name=content::$content"

- name: setup node
uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
# See https://github.com/actions/setup-node/issues/32
node-version: ${{ steps.nodejs-version.outputs.content }}
node-version-file: '.nvmrc'

- name: clean install dependencies
run: npm ci
run: npm ci

- name: compile and create vsix
run: npm run package -- -o extension.vsix

Expand Down
13 changes: 2 additions & 11 deletions .github/workflows/preview.yml
View file
Open in desktop
Expand Up @@ -24,18 +24,9 @@ jobs:
content=`cat ./package.json | jq -r .version`
echo "::set-output name=content::$content"

- name: Read Node.js version
id: nodejs-version
run: |
content=`cat ./.nvmrc`
echo "::set-output name=content::$content"

- name: Set up Node.js
uses: actions/setup-node@v2
- uses: actions/setup-node@v2
with:
# See https://github.com/actions/setup-node/issues/32
node-version: ${{ steps.nodejs-version.outputs.content }}
cache: 'npm'
node-version-file: '.nvmrc'

- name: Install dependencies
run: npm ci
Expand Down
11 changes: 2 additions & 9 deletions .github/workflows/publish.yml
View file
Open in desktop
Expand Up @@ -24,16 +24,9 @@ jobs:
echo "Received ref: ${{ github.ref }}"
echo "Expected ref: refs/tags/v${{ steps.ext-version.outputs.content }}"
exit 1
- name: Read Node.js version
id: nodejs-version
run: |
content=`cat ./.nvmrc`
echo "::set-output name=content::$content"
- name: Set up Node.js
uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
# See https://github.com/actions/setup-node/issues/32
node-version: ${{ steps.nodejs-version.outputs.content }}
node-version-file: '.nvmrc'
- name: Install dependencies
run: npm ci
- name: vsce package
Expand Down
54 changes: 7 additions & 47 deletions .github/workflows/test.yml
View file
Open in desktop
Expand Up @@ -15,17 +15,9 @@ jobs:
steps:
- name: Checkout Repo
uses: actions/checkout@v2
-
name: Read Node.js version (Unix)
id: nodejs-version
run: |
content=`cat ./.nvmrc`
echo "::set-output name=content::$content"
- name: Setup Node.js
uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
# See https://github.com/actions/setup-node/issues/32
node-version: ${{ steps.nodejs-version.outputs.content }}
node-version-file: '.nvmrc'
- name: npm install
run: npm install
- name: lint
Expand All @@ -45,25 +37,9 @@ jobs:
steps:
- name: Checkout Repo
uses: actions/checkout@v2
-
name: Read Node.js version (Unix)
if: ${{ runner.os != 'Windows' }}
id: nodejs-version-unix
run: |
content=`cat ./.nvmrc`
echo "::set-output name=content::$content"
-
name: Read Node.js version (Windows)
if: ${{ runner.os == 'Windows' }}
id: nodejs-version-win
run: |
$content = Get-Content .\.nvmrc -Raw
echo "::set-output name=content::$content"
- name: Setup Node.js
uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
# See https://github.com/actions/setup-node/issues/32
node-version: ${{ steps.nodejs-version-unix.outputs.content || steps.nodejs-version-win.outputs.content }}
node-version-file: '.nvmrc'
- name: npm install
run: npm ci
- name: unit test
Expand All @@ -83,25 +59,9 @@ jobs:
steps:
- name: Checkout Repo
uses: actions/checkout@v2
-
name: Read Node.js version (Unix)
if: ${{ runner.os != 'Windows' }}
id: nodejs-version-unix
run: |
content=`cat ./.nvmrc`
echo "::set-output name=content::$content"
-
name: Read Node.js version (Windows)
if: ${{ runner.os == 'Windows' }}
id: nodejs-version-win
run: |
$content = Get-Content .\.nvmrc -Raw
echo "::set-output name=content::$content"
- name: Setup Node.js
uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
# See https://github.com/actions/setup-node/issues/32
node-version: ${{ steps.nodejs-version-unix.outputs.content || steps.nodejs-version-win.outputs.content }}
node-version-file: '.nvmrc'
- name: Set up Xvfb (Ubuntu)
run: |
/usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
Expand All @@ -111,7 +71,7 @@ jobs:
uses: hashicorp/setup-terraform@v1
with:
terraform_wrapper: false
terraform_version: "~1.0"
terraform_version: '~1.0'
- name: Clean Install Dependencies
run: npm ci
- name: Run Tests
Expand Down