-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vscode-languageclient to 9.0.1 #1732
Conversation
7e70d10
to
60db287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Do you expect any issues with this major bump? Should we include it in the 2.30.0 release?
5989ee0
to
b2d56a1
Compare
The 9.0.1 version was released 6 months ago, so any issues should have been raised by now. We do have to bump the engine from from 1.82.3 to 1.86.X. This may require waiting until the next release as we have several things pending right now I don't want to lose the version for. |
2b590c4
to
e36a89d
Compare
1c60094
to
787a8d5
Compare
This updates the vscode-languageclient package to 9.0.1. This is a major update that includes a number of changes, including a new dependency on vscode-jsonrpc 8.2.0 and vscode-languageserver-protocol 3.17.5 NOTE: This requires bumping the minimum supported VS Code version to 1.86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think the only thing missing is bumping the types (@types/vscode
) to 1.86.0 as well
33ec817
to
5b03863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This updates the vscode-languageclient package to 9.0.1. This is a major update that includes a number of changes, including a new dependency on vscode-jsonrpc 8.2.0 and vscode-languageserver-protocol 3.17.5
NOTE: This requires bumping the minimum supported VS Code version to 1.86