Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-languageclient to 9.0.1 #1732

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Apr 3, 2024

This updates the vscode-languageclient package to 9.0.1. This is a major update that includes a number of changes, including a new dependency on vscode-jsonrpc 8.2.0 and vscode-languageserver-protocol 3.17.5

NOTE: This requires bumping the minimum supported VS Code version to 1.86

@jpogran jpogran self-assigned this Apr 3, 2024
@jpogran jpogran force-pushed the update_langaugeclient_9.0 branch 2 times, most recently from 7e70d10 to 60db287 Compare April 3, 2024 20:12
@jpogran jpogran marked this pull request as ready for review April 3, 2024 20:23
@jpogran jpogran requested a review from a team as a code owner April 3, 2024 20:23
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do you expect any issues with this major bump? Should we include it in the 2.30.0 release?

src/features/languageStatus.ts Outdated Show resolved Hide resolved
@jpogran
Copy link
Contributor Author

jpogran commented Apr 9, 2024

Nice! Do you expect any issues with this major bump? Should we include it in the 2.30.0 release?

The 9.0.1 version was released 6 months ago, so any issues should have been raised by now.

We do have to bump the engine from from 1.82.3 to 1.86.X. This may require waiting until the next release as we have several things pending right now I don't want to lose the version for.

@jpogran jpogran marked this pull request as draft April 9, 2024 17:45
@jpogran jpogran force-pushed the update_langaugeclient_9.0 branch from 2b590c4 to e36a89d Compare May 2, 2024 17:44
@jpogran jpogran force-pushed the update_langaugeclient_9.0 branch 2 times, most recently from 1c60094 to 787a8d5 Compare May 10, 2024 14:20
@jpogran jpogran marked this pull request as ready for review May 10, 2024 14:21
This updates the vscode-languageclient package to 9.0.1. This is a major update that includes a number of changes, including a new dependency on vscode-jsonrpc 8.2.0 and vscode-languageserver-protocol 3.17.5

NOTE: This requires bumping the minimum supported VS Code version to 1.86
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think the only thing missing is bumping the types (@types/vscode) to 1.86.0 as well

@jpogran jpogran force-pushed the update_langaugeclient_9.0 branch from 33ec817 to 5b03863 Compare May 14, 2024 17:41
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jpogran jpogran merged commit b695170 into main May 15, 2024
19 checks passed
@jpogran jpogran deleted the update_langaugeclient_9.0 branch May 15, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants