Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for custom tfcloud host #1678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Convez
Copy link
Contributor

@Convez Convez commented Jan 25, 2024

This is a simplified version of PR #1673 , as requested
This closes #1671 and closes #1505
Allow TFC host selection during login. Hosts already in TFC credentials file are displayed. Options for insertion of new hosts added:
image
image

N.B. Logging to a new hostname does not update the TFC credentials file (Maybe to be implemented in the future?)

@Convez Convez requested a review from a team as a code owner January 25, 2024 08:57
@Convez Convez changed the title Prompt for custom tfcloud host [Simplified PR] - Prompt for custom tfcloud host Jan 25, 2024
@Convez Convez changed the title [Simplified PR] - Prompt for custom tfcloud host Prompt for custom tfcloud host Feb 5, 2024
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Convez, thanks for the updated PR. I appreciate your patience with the delays in reviewing your original PR and this one. I'm grateful for your continued contributions. The delay is not a reflection of the importance of your contributions, it's a result of new priorities and the need to manage shifting timelines.

For now, with your permission, I can do a couple of things to get some forward movement here. I would like to extract the bug fix for the Terraform credential path on Windows myself into a separate PR and attribute you for it. Then I'll rebase this PR so there is not so many merge commits in it and get it in a ready to review state. My team will be discussing TFE support in our quarterly planning in 2 weeks, after that I will let you know the results of that meeting and how that applies to this PR.

I again thank you for your patience.

@jpogran
Copy link
Contributor

jpogran commented Apr 15, 2024

Hey @Convez, I've extracted and merged #1735, which contains your bug fix for the credentials file.

With your permission I can rebase this PR against main and keep i up to date.

@willjprice
Copy link

Bump.

@Convez
Copy link
Contributor Author

Convez commented May 30, 2024

Hey @Convez, I've extracted and merged #1735, which contains your bug fix for the credentials file.

With your permission I can rebase this PR against main and keep i up to date.

Yes, of course. Thank you very much. Sorry for the (very) late reply

@jpogran jpogran force-pushed the feat/custom-tfcloud-host-simple branch from 9d8a9fb to 51dd4a7 Compare May 30, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow terraform cloud instances other than app.terraform.io Support Terraform Enterprise in the TFC view
3 participants