Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SelectableCards from click events when disabled #27057

Merged
merged 4 commits into from
May 15, 2024

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented May 15, 2024

Previously:

Screen.Recording.2024-05-15.at.2.08.06.PM.mov

With Fix:

fix.mov

Guessing a backport to 1.16.x as I think this might have been the regression pr.

@Monkeychip Monkeychip added ui bug Used to indicate a potential bug pr/no-changelog labels May 15, 2024
@Monkeychip Monkeychip added this to the 1.17.0-rc milestone May 15, 2024
@Monkeychip Monkeychip requested a review from a team as a code owner May 15, 2024 20:34
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented May 15, 2024

CI Results:
All Go tests succeeded! ✅

Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo fix, otherwise 🚀

ui/tests/integration/components/selectable-card-test.js Outdated Show resolved Hide resolved
Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
@Monkeychip Monkeychip enabled auto-merge (squash) May 15, 2024 22:31
@Monkeychip Monkeychip merged commit 0d94bac into main May 15, 2024
31 checks passed
@Monkeychip Monkeychip deleted the ui/VAULT-27181/click-disabled-engine branch May 15, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants