UI: Ember 5 deprecation stragglers #26666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
1 task
|
Build Results: |
noelledaley
approved these changes
Apr 30, 2024
| @@ -68,6 +68,8 @@ module('Acceptance | secrets/secret/create, read, delete', function (hooks) { | |||
| assert | |||
| .dom(PAGE.infoRowValue('Automate secret deletion')) | |||
| .hasText('1 second', 'displays the delete version after set when configuring the secret-engine'); | |||
| // [BANDAID] avoid error from missing param for links in SecretEdit > KeyValueHeader | |||
| await visit('/vault/secrets'); | |||
There was a problem hiding this comment.
ah darn, are adding those missing params something we can add easily in a different PR, or does it require a bigger change?
There was a problem hiding this comment.
KeyValueHeader already has a lot of complex logic, so it's not a simple fix. Ideally we want to replace that with Page::Breadcrumbs anyway, so it didn't feel worth the effort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps up ember 5 upgrade deprecations and fixes the test failures that happened after some of those deprecations were cleaned up.
Related PRs:
UI: Update transit links #26689
UI: add backend to secret link #26683
UI: Update custom message list filters #26653
UI: Add necessary params to links in PKI #26608
UI: Add necessary params to links in Access & KV v2 #26561
Ent tests pass