Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-24619: bump go version to 1.22.2 for 1.16.x #26652

Merged
merged 2 commits into from Apr 30, 2024

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented Apr 25, 2024

This PR also upgrades layeh.com/radius as there were tests failing with the following panics:

panic: runtime error: slice bounds out of range [:16] with capacity 4 [recovered]
	panic: runtime error: slice bounds out of range [:16] with capacity 4

goroutine 63 [running]:
testing.tRunner.func1.2({0x2cf0880, 0xc0009fe000})
	/opt/hostedtoolcache/go/1.22.2/x64/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.22.2/x64/src/testing/testing.go:1634 +0x377
panic({0x2cf0880?, 0xc0009fe000?})
	/opt/hostedtoolcache/go/1.22.2/x64/src/runtime/panic.go:770 +0x132
layeh.com/radius.NewUserPassword({0x2f0ee0f, 0x4, 0x4}, {0xc001754ee0, 0xa, 0x10}, {0xc001512349, 0x10, 0x10})
	/home/runner/go/pkg/mod/layeh.com/radius@v0.0.0-20190322222518-890bc1058917/attribute.go:207 +0x525
layeh.com/radius/rfc2865.UserPassword_SetString(0xc001512340, {0x2f0ee0f?, 0x1?})

This issue was fixed about 7 months ago in layeh/radius@6c2c615. Unfortunately, the library does not tag its releases. Hopefully it is safe to move to latest but I'm interested if anyone with more context on the dependency has any issue with moving that far ahead.

@ccapurso ccapurso added this to the 1.16.3 milestone Apr 25, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

CI Results:
All Go tests succeeded! ✅

@ccapurso ccapurso marked this pull request as ready for review April 26, 2024 16:52
@ccapurso ccapurso requested a review from a team April 26, 2024 16:52
Copy link

Build Results:
All builds succeeded! ✅

@ccapurso ccapurso merged commit 5bbdd43 into release/1.16.x Apr 30, 2024
117 checks passed
@ccapurso ccapurso deleted the vault-24619-go-1.22.2-upgrade-1.16.x branch April 30, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants