Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Updating Kubernetes upgrade instruction #25286

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

framsouza
Copy link

@framsouza framsouza requested a review from a team as a code owner February 8, 2024 10:06
framsouza and others added 2 commits April 16, 2024 16:52
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
@framsouza framsouza requested a review from a team as a code owner April 16, 2024 14:54
Comment on lines +453 to +455
Removing a pod without deleting the node from its cluster first means that the
number of nodes Raft
will be unaware of the correct number of nodes in the cluster. This can trigger a leader election, potentially causing downtime.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Removing a pod without deleting the node from its cluster first means that the
number of nodes Raft
will be unaware of the correct number of nodes in the cluster. This can trigger a leader election, potentially causing downtime.
Removing a pod without first deleting the node from its cluster means that
Raft will be aware of the correct number of nodes in the cluster. Not knowing
the correct number of nodes can trigger a leader election, which can potentially
cause unneeded downtime.

Style correction: writein active voice, avoid "this" as a pronoun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants