New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Updating Kubernetes upgrade instruction #25286
Open
framsouza
wants to merge
5
commits into
hashicorp:main
Choose a base branch
from
framsouza:docs-fix-k8s-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
framsouza
commented
Feb 8, 2024
- Updating Vault Upgrade instructions on Kubernetes to avoid leader election while deleting one pod
- Potential cause/fix for [1.15.4] Raft leader election unexpected behavior [1.15.4] Raft leader election unexpected behavior #24995
schavis
requested changes
Feb 21, 2024
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
schavis
requested changes
May 9, 2024
Comment on lines
+453
to
+455
Removing a pod without deleting the node from its cluster first means that the | ||
number of nodes Raft | ||
will be unaware of the correct number of nodes in the cluster. This can trigger a leader election, potentially causing downtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Removing a pod without deleting the node from its cluster first means that the | |
number of nodes Raft | |
will be unaware of the correct number of nodes in the cluster. This can trigger a leader election, potentially causing downtime. | |
Removing a pod without first deleting the node from its cluster means that | |
Raft will be aware of the correct number of nodes in the cluster. Not knowing | |
the correct number of nodes can trigger a leader election, which can potentially | |
cause unneeded downtime. |
Style correction: writein active voice, avoid "this" as a pronoun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.