Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: KV version 2 advanced secret updates #25235

Merged
merged 9 commits into from Feb 6, 2024
Merged

UI: KV version 2 advanced secret updates #25235

merged 9 commits into from Feb 6, 2024

Conversation

hashishaw
Copy link
Collaborator

This PR makes the following changes to the KV version 2 secret interface:

  • no longer disables the JSON toggle when the key values are a non-string (but it still defaults to true when values are non-string)
  • Defaults to obscure values when viewing secret as JSON
shows obscured JSON values
  • adds a warning when trying to enter a non-string value with the non-JSON interface
shows warning
  • "Show diff" toggle is no longer disabled when no changes are made (for accessibility)
Shows enabled diff when no changes

@hashishaw hashishaw added the ui label Feb 6, 2024
@hashishaw hashishaw added this to the 1.16.0-rc1 milestone Feb 6, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 6, 2024
@hashishaw hashishaw linked an issue Feb 6, 2024 that may be closed by this pull request
Reversion or Enhancement of Secret Display Post-PR #24290 for Improved Security and Usability #24839
Closed
@hashishaw hashishaw mentioned this pull request Feb 6, 2024
Closed
4 tasks
@hashishaw hashishaw modified the milestones: 1.16.0-rc1, 1.15.6 Feb 6, 2024
@hashishaw hashishaw added the backport/1.15.x Backport changes to `release/1.15.x` label Feb 6, 2024
Monkeychip
Monkeychip approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I checked out locally and did my best to break things and couldn't.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Build Results:
All builds succeeded! ✅

@hashishaw hashishaw merged commit 7c14aa6 into main Feb 6, 2024
72 checks passed
@hashishaw hashishaw deleted the ui/VAULT-23727/never-disable-json-toggle branch February 6, 2024 17:50
hashishaw added a commit that referenced this pull request Feb 6, 2024
@hashishaw
UI: KV version 2 advanced secret updates (#25235)
08eaac1 
* Add obfuscation for JSON values on KV data view

* Show JSON editor by default if secret data is complex, but do not disable JSON toggle

* Add text object warning to kv object editor

* a11y fix: do not disable show diff toggle

* test and language cleanup

* update language

* Update tests for expected behavior

* language!

* Add changelog
@hashishaw hashishaw mentioned this pull request Feb 6, 2024
Merged
Monkeychip pushed a commit that referenced this pull request Feb 7, 2024
@hashishaw @Monkeychip
UI: KV version 2 advanced secret updates (#25235)
69880f5 
* Show JSON editor by default if secret data is complex, but do not disable JSON toggle

* Add text object warning to kv object editor

* a11y fix: do not disable show diff toggle

* test and language cleanup

* update language

* Update tests for expected behavior

* language!

* Add changelog
@hellobontempo hellobontempo mentioned this pull request Feb 7, 2024
Merged
hashishaw added a commit that referenced this pull request Feb 14, 2024
@hashishaw
Backport UI: KV version 2 advanced secret updates to 1.15.x (#25235) (#…
5d3dbf9 
…25238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
backport/1.15.x Backport changes to `release/1.15.x` hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.15.6
Development

Successfully merging this pull request may close these issues.

Reversion or Enhancement of Secret Display Post-PR #24290 for Improved Security and Usability
2 participants
@hashishaw @Monkeychip