Backport of Calculate namespace prefix before tainting route entries into release/1.14.x #21485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/violethynes/fix-taint-namespace-prefixes/correctly-immune-goshawk
branch
2 times, most recently
from
0b11675
to
5d0ea33
Compare
VioletHynes
approved these changes
Jun 27, 2023
VioletHynes
deleted the
backport/violethynes/fix-taint-namespace-prefixes/correctly-immune-goshawk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21470 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
This is essentially the 'fix' code we used as part of resolving a recent sev 1, where we pre-calculate the namespace path, as we do in the other place we call
c.router.Taint(ctx, path). The PR for that change is here: #15067 . I added debug logging including the places where we disagree, and added it to the other place we pre-calculate namespace prefixes.There may be more adjustments/improvements we want to make to add additional safety to tainting, such as preventing the root "sys/" from ever being tainted, but if we did want to add those, we can do as part of a different PR. I wanted to keep this PR with a small scope, specifically targeting the fix.
Overview of commits