backports for HLL estimates in ActivityLog 1.11.x #21220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmi
requested review from
raskchanky,
banks,
miagilepner,
hc-github-team-secure-vault-core and
hghaf099
mpalmi
force-pushed
the
hll-backport-1.11.x
branch
from
4588aec
to
25fcbcf
Compare
mpalmi
force-pushed
the
hll-backport-1.11.x
branch
from
25fcbcf
to
35d8952
Compare
raskchanky
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encapsulates the backports for ActivityLog changes to get more correct current month estimates using HLL sketches.
This is a pre-cursor to the ActivityLog backport for 1.11.x. Once merged, we can rebase that PR to get feature parity across 1.11-1.14.
Apologies for the large PR. It may be easiest to review by comparing each backport commit with the original. I can split this up if others think it's worthwhile.