Request forwarding #1721
Merged
Request forwarding #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
force-pushed
the
request-forwarding
branch
11 times, most recently
from
9caf4ee
to
1c87bc7
Compare
Normal unit tests suffice here, for the moment, as nearly all requests now route through it and will choose the non-HA/leader path.
rereading JSON unnecessarily in Leader()
…om listening ports
function. More documentation updates are needed.
This actually ends up being much easier, because we have a single source of truth (the advertised info) rather than trying to reconcile against other locations in the barrier that may be cached. Also fix some bugs after fixing service-tags -> service_tags.
jefferai
force-pushed
the
request-forwarding
branch
from
26b874d
to
d497de4
Compare
| // assume it's due to there not being a port specified, in which case | ||
| // use 443 | ||
| host = u.Host | ||
| nPort = 443 |
There was a problem hiding this comment.
should we set nPortErr to nil here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #443