Cleanup changes around issuer revocation #16874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendpclark
approved these changes
Aug 24, 2022
cipherboy
commented
Aug 25, 2022
| // set, if it is a member. | ||
| // | ||
| // If it is, we'll also pull in the unassigned certs to remain | ||
| // compatible with Vault's earlier, potentially questionable |
There was a problem hiding this comment.
Should we add this as a gating flag in CRL config?
There was a problem hiding this comment.
That's a really good idea (though maybe not in scope of this PR)
cipherboy
force-pushed
the
cipherboy-cleanup-issuer-revocation
branch
from
2f6ac55
to
941d5a8
Compare
kitography
approved these changes
Aug 25, 2022
| // set, if it is a member. | ||
| // | ||
| // If it is, we'll also pull in the unassigned certs to remain | ||
| // compatible with Vault's earlier, potentially questionable |
There was a problem hiding this comment.
That's a really good idea (though maybe not in scope of this PR)
Thanks Steve for the approach! This also address nits from Kit. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
This skips a number of steps during CRL build when it is disabled (and forceNew is not set). In particular, we avoid fetching issuers, we avoid associating issuers with revocation entries (and building that in-memory mapping), making CRL building more efficient. This means that there'll again be very little overhead on clusters with the CRL disabled. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
This change ensures that when marking a root as revoked, it no longer appears on its own CRL. Very few clients support this event (as generally only leaves/intermediates are checked for presence on a parent's CRL) and it is technically undefined behavior (if the root is revoked, its own CRL should be untrusted and thus including it on its own CRL isn't a safe/correct distribution channel). Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
As mentioned by Kit, iterating through each revInfoEntry and associating the first issuer which matches it can cause churn when many (equivalent) issuers are in the system and issuers come and go (via CRLSigning usage, which has been modified in this release as well). Because we'd not include issuers without CRLSigning usage, we'd cause our verification helper, isRevInfoIssuerValid, to think the issuer ID is no longer value (when instead, it just lacks crlSigning bits). We address this by pulling in all issuers we know of for the identification. This allows us to keep valid-but-not-for-signing issuers, and use other representatives of their identity set for signing/building the CRL (if they are enabled for such usage). As a side effect, we now no longer place these entries on the default CRL in the event all issuers in the CRL set are without the usage. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
This is only for the last commit. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-cleanup-issuer-revocation
branch
from
2aacf10
to
a54c086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes four incremental improvements to revocation (around issuers and otherwise):
IMO, existing tests should cover most of this behavior, but let me know if you want me to add explicit tests for certain things.
I think only the latter deserves a changelog entry (given 2 can mostly be covered by the tidy update's changelog) but let me know.