Update mount table and CLI with plugin version for auth #16856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
changed the title
tvoran
reviewed
Aug 24, 2022
swenson
force-pushed
the
vault-7744/mount-table-version
branch
2 times, most recently
from
644d9f3
to
e9d10a4
Compare
tomhjp
reviewed
Aug 25, 2022
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
swenson
force-pushed
the
vault-7744/mount-table-version
branch
from
f63c42a
to
f699be4
Compare
|
I'm hesitant to merge this without approval for the extra commits I've made. But feel free to modify or merge this in my absence (as I'll be out for the next week). |
tomhjp
approved these changes
Aug 30, 2022
command/plugin_deregister.go
Outdated
| @@ -33,7 +34,7 @@ Usage: vault plugin deregister [options] TYPE NAME | |||
|
|
|||
| Deregister the plugin named my-custom-plugin: | |||
|
|
|||
| $ vault plugin deregister auth my-custom-plugin | |||
| $ vault plugin deregister auth my-custom-plugin [version] | |||
There was a problem hiding this comment.
Should we use a flag instead of positional arg here for consistency?
There was a problem hiding this comment.
👍 Saw you did that in a follow-up commit. I think I was trying to avoid the version / plugin_version confusion, but it's not as relevant here as it is for mounts.
command/plugin_deregister.go
Outdated
Comment on lines
107
to
109
| // Canonicalize the version string. | ||
| // Add the 'v' back in, since semantic version strips it out, and we want to be consistent with internal plugins. | ||
| pluginVersion = "v" + semanticVersion.String() |
There was a problem hiding this comment.
I don't think there should be any need to canonicalise here - the server should accept it with or without the v
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CLI and API to support plugin versions, and specifically targets updating the auth plugin machinery to support versions.
I'm targeting #16688 for now to minimize conflicts, but I can re-target against
mainif #16688 gets merged.