Handle multiple matching issuers in OCSP requests #16848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Select the first issuer that matches our request hashes and has the OCSP signing usage enabled. This might not match the exact issuer id that issued the certificate but the signatures will be okay.
kitography
approved these changes
Aug 23, 2022
cipherboy
approved these changes
Aug 24, 2022
stevendpclark
deleted the
stevendpclark/vault-7900-ocsp-multiple-issuer-matching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select the first issuer that matches our request hashes and has the OCSP signing usage enabled. This might not match the exact issuer id that issued the certificate but the signatures will be okay.
This should resolve the comment brought up by @kitography in PR#16723. Thanks again for identifying this issue in the review!