Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secret/database: fix bug where too many wal deletes are deferred #16686

Merged
merged 3 commits into from Aug 11, 2022
Merged

secret/database: fix bug where too many wal deletes are deferred #16686

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29a9624
secret/database: fix bug where too many wal deletes are deferred
jasonodonnell Aug 11, 2022
03c221f
changelog
jasonodonnell Aug 11, 2022
88ab98c
Update changelog/16686.txt
jasonodonnell Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion builtin/logical/database/rotation.go
View file
Open in desktop
Expand Up @@ -537,7 +537,7 @@ func (b *databaseBackend) initQueue(ctx context.Context, conf *logical.BackendCo
}

walID, err := framework.PutWAL(ctx, conf.StorageView, staticWALKey, &setCredentialsWAL{RoleName: "vault-readonlytest"})
if walID != "" {
if walID != "" && err == nil {
defer framework.DeleteWAL(ctx, conf.StorageView, walID)
}
switch {
Expand Down
3 changes: 3 additions & 0 deletions changelog/16686.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:bug
plugin/secrets/database: Fix a bug where the secret engine would queue up a lot of WAL deletes during startup.
jasonodonnell marked this conversation as resolved.
Show resolved Hide resolved
```