Remove SHA1 for certs in prep for Go 1.18 #16455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
swenson
commented
Jul 26, 2022
swenson
commented
- Remove certs with SHA1 from tests
- Use default SHA-256 with PKCS7 in AWS
- Update SHA1 deprecation note
* Remove certs with SHA1 from tests * Use default SHA-256 with PKCS7 in AWS * Update SHA1 deprecation note
|
I confirmed that all tests pass locally with Go 1.18 on |
tvoran
approved these changes
Jul 27, 2022
| case *dsa.PrivateKey: | ||
| template.SignatureAlgorithm = x509.DSAWithSHA1 | ||
| } | ||
| priv = &dsaPriv | ||
| } |
There was a problem hiding this comment.
I wonder if there should be a default case here that throws an error if sigAlg isn't one of the known cases?
There was a problem hiding this comment.
Possibly. But not critical I think since this is only in a _test.go file.
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.