Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Increase the allowed concurrent gRPC streams into release/1.9.x #16382

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16327 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


By default http2.Server allows for 250 concurrent streams per host. This limit can cause bottlenecks on clusters with many forwarded requests/rpcs. This changes the default to match what the gRPC library uses: MaxUint32.


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 20, 2022

CLA assistant check
All committers have signed the CLA.

@briankassouf briankassouf marked this pull request as ready for review July 20, 2022 23:34
* Increase the allowed concurrent gRPC streams

* Add a env override for the max streams setting

* Add changelog

* go fmt

* fix builds on 32bit systems
@briankassouf briankassouf force-pushed the backport/grpc-concurrent-limit/adversely-wealthy-scorpion branch from d91b190 to b322eb6 Compare July 20, 2022 23:43
@briankassouf briankassouf enabled auto-merge (squash) July 20, 2022 23:45
@briankassouf briankassouf merged commit 18be7fd into release/1.9.x Jul 20, 2022
@briankassouf briankassouf deleted the backport/grpc-concurrent-limit/adversely-wealthy-scorpion branch July 20, 2022 23:58
@briankassouf briankassouf added this to the 1.9.9 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants