Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the allowed concurrent gRPC streams #16327

Merged
merged 5 commits into from Jul 20, 2022
Merged

Increase the allowed concurrent gRPC streams #16327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e19cb88
Increase the allowed concurrent gRPC streams
briankassouf Jul 18, 2022
3f069e5
Add a env override for the max streams setting
briankassouf Jul 20, 2022
b8e48d0
Add changelog
briankassouf Jul 20, 2022
a97273a
go fmt
briankassouf Jul 20, 2022
7facd6b
fix builds on 32bit systems
briankassouf Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/16327.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:bug
core: Increase the allowed concurrent gRPC streams over the cluster port.
```
17 changes: 17 additions & 0 deletions vault/cluster/cluster.go
View file
Open in desktop
Expand Up @@ -6,9 +6,11 @@ import (
"crypto/x509"
"errors"
"fmt"
"math"
"net"
"net/url"
"os"
"strconv"
"sync"
"sync/atomic"
"time"
Expand Down Expand Up @@ -73,6 +75,17 @@ type Listener struct {
}

func NewListener(networkLayer NetworkLayer, cipherSuites []uint16, logger log.Logger, idleTimeout time.Duration) *Listener {
var maxStreams uint32 = math.MaxUint32
if override := os.Getenv("VAULT_GRPC_MAX_STREAMS"); override != "" {
i, err := strconv.ParseUint(override, 10, 32)
if err != nil {
logger.Warn("vault grpc max streams override must be an uint32 integer", "value", override)
} else {
maxStreams = uint32(i)
logger.Info("overriding grpc max streams", "value", i)
}
}

// Create the HTTP/2 server that will be shared by both RPC and regular
// duties. Doing it this way instead of listening via the server and gRPC
// allows us to re-use the same port via ALPN. We can just tell the server
Expand All @@ -81,6 +94,10 @@ func NewListener(networkLayer NetworkLayer, cipherSuites []uint16, logger log.Lo
// Our forwarding connections heartbeat regularly so anything else we
// want to go away/get cleaned up pretty rapidly
IdleTimeout: idleTimeout,

// By default this is 250 which can be too small on high traffic
// clusters with many forwarded or replication gRPC connections.
MaxConcurrentStreams: maxStreams,
}

return &Listener{
Expand Down