Backport of ssh: Fix template regex test for defaultExtensions to allow additional text into release/1.10.x #16037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…l text (#16018) * ssh: Fix template regex test for defaultExtensions - The regex to identify if our defaultExtensions contains a template was a little too greedy, requiring the entire field to be just the regex. Allow additional text within the value field to be added * Add cl
stevendpclark
force-pushed
the
backport/stevendpclark/vault-6115-ssh-template/mostly-worthy-turtle
branch
from
a25927b
to
a7a891f
Compare
stevendpclark
approved these changes
Jun 17, 2022
cipherboy
approved these changes
Jun 17, 2022
stevendpclark
deleted the
backport/stevendpclark/vault-6115-ssh-template/mostly-worthy-turtle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16018 to be assessed for backporting due to the inclusion of the label backport/1.10.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
a little too greedy, requiring the entire field to be just the regex. Allow
additional text within the value field to be added
Overview of commits