Backport of VAULT-5935 agent: redact renew-self if using auto auth into release/1.9.x #15397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
swenson
force-pushed
the
backport/VAULT-5935-redact-renew-self/vaguely-quality-skunk
branch
from
fbc10cf
to
c9de4ef
Compare
Vault agent redacts the token and accessor for `/auth/token/lookup-self` (and `lookup`) if the token is the auto auth token to prevent it from leaking. Similarly, we need to redact the token and accessor from `renew-self` and `renew`, which also leak the token and accessor. I tested this locally by starting up a Vault agent and querying the agent endpoints, and ensuring that the accessor and token were set to the empty string in the response.
swenson
force-pushed
the
backport/VAULT-5935-redact-renew-self/vaguely-quality-skunk
branch
from
c9de4ef
to
b1cdf3a
Compare
tomhjp
approved these changes
May 12, 2022
swenson
deleted the
backport/VAULT-5935-redact-renew-self/vaguely-quality-skunk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15380 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Vault agent redacts the token and accessor for
/auth/token/lookup-self(andlookup)if the token is the auto auth token to prevent it from leaking.
Similarly, we need to redact the token and accessor from
renew-selfand
renew, which also leak the token and accessor.I tested this locally by starting up a Vault agent and querying the
agent endpoints, and ensuring that the accessor and token were set to
the empty string in the response.