Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report listener and storage types as found keys #15383

Merged
merged 2 commits into from May 12, 2022
Merged

report listener and storage types as found keys #15383

merged 2 commits into from May 12, 2022

Conversation

HridoyRoy
Copy link
Contributor

This PR fixes #15331

hghaf099
hghaf099 reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@hghaf099 hghaf099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one question, otherwise looks good!

command/server/config.go Show resolved Hide resolved
sgmiller
sgmiller approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@sgmiller sgmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve apart from hghaf099's comment

@HridoyRoy HridoyRoy merged commit 79df79f into main May 12, 2022
@HridoyRoy HridoyRoy deleted the vault-6169-2 branch May 12, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hghaf099 hghaf099 hghaf099 left review comments

@sgmiller sgmiller sgmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unknown or unsupported field - consul and tcp
3 participants
@HridoyRoy @sgmiller @hghaf099