Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PKI types to avoid constant variable name collisions #15101

Closed

Conversation

stevendpclark
Copy link
Contributor

keyId -> keyID
issuerId -> issuerID
key -> keyEntry
issuer -> issuerEntry
keyConfig -> keyConfigEntry
issuerConfig -> issuerConfigEntry

Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a fairly straightforward rename.

 keyId -> keyID
 issuerId -> issuerID
 key -> keyEntry
 issuer -> issuerEntry
 keyConfig -> keyConfigEntry
 issuerConfig -> issuerConfigEntry
@stevendpclark stevendpclark force-pushed the stevendpclark/pki-type-renaming branch from 17c2a7e to 730d9a0 Compare April 20, 2022 19:55
@stevendpclark
Copy link
Contributor Author

Manually merged into pki-pod-rotation.

@stevendpclark stevendpclark deleted the stevendpclark/pki-type-renaming branch April 20, 2022 20:03
@cipherboy
Copy link
Contributor

This PR was merged in #15277. See that PR and the relevant docs PR #15238 for more information about this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants