Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKI migration writes out empty migration log entry #15091

Merged

Conversation

stevendpclark
Copy link
Contributor

  • Since the elements of the struct were not exported we serialized an empty
    migration log to disk and would re-run the migration

Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

builtin/logical/pki/storage_migrations_test.go Outdated Show resolved Hide resolved
 - Since the elements of the struct were not exported we serialized an empty
   migration log to disk and would re-run the migration
@stevendpclark stevendpclark force-pushed the stevendpclark/fix-migration-log-write-issue branch from 699abf5 to 0a94ae1 Compare April 19, 2022 16:53
@stevendpclark stevendpclark merged commit 0a94ae1 into pki-pod-rotation Apr 19, 2022
@stevendpclark stevendpclark deleted the stevendpclark/fix-migration-log-write-issue branch April 19, 2022 20:27
@cipherboy
Copy link
Contributor

This PR was merged in #15277. See that PR and the relevant docs PR #15238 for more information about this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants