Backport of fix TypeCommaIntSlice panic caused by json.Number input into release/1.8.x #15081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/fix-TypeCommaIntSlice-json-number-panic/formerly-pleasant-wildcat
branch
from
f394512
to
d3dfd2c
Compare
raskchanky
approved these changes
Apr 18, 2022
|
For code changes it would be better to get a second approval. You can approve yourself for backported docs changes. Edit: I need to clarify this in the backport assistant documentation. |
ccapurso
deleted the
backport/fix-TypeCommaIntSlice-json-number-panic/formerly-pleasant-wildcat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15072 to be assessed for backporting due to the inclusion of the label backport/1.8.x.
The below text is copied from the body of the original PR.
Vault will panic when it attempts to parse fields with a schema of
TypeCommaIntSliceif the provided value is an integer specifically if provided within the JSON body of an HTTP request. This is similar to a recent fix that was implemented forTypeCommaStringSlicewhich was fixed in #14522. The issue resides inmapstructure.StringToSliceHookFunc.The fix provided in this pull request is to check if the raw input is of type
json.Numberand then callingString().Fixes #15057