Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: secrets/auth plugin multiplexing #14946

Merged
merged 69 commits into from Aug 30, 2022
Merged

feature: secrets/auth plugin multiplexing #14946

merged 69 commits into from Aug 30, 2022

Commits on Aug 2, 2022

  1. enable registering backend muxed plugins in plugin catalog

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    a702d4b View commit details
    Browse the repository at this point in the history

  2. set the sysview on the pluginconfig to allow enabling secrets/auth pl… 

    …ugins
    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    999c5d5 View commit details
    Browse the repository at this point in the history

  3. store backend instances in map

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    9dd31c5 View commit details
    Browse the repository at this point in the history

  4. store single implementations in the instances map 

    cleanup instance map and ensure we don't deadlock
    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    d25e042 View commit details
    Browse the repository at this point in the history

  5. fix system backend unit tests 

    move GetMultiplexIDFromContext to pluginutil package

fix pluginutil test

fix dbplugin ut
    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    c7b4e26 View commit details
    Browse the repository at this point in the history

  6. return error(s) if we can't get the plugin client 

    update comments
    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    270de0a View commit details
    Browse the repository at this point in the history

  7. refactor/move GetMultiplexIDFromContext test

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    7a9f116 View commit details
    Browse the repository at this point in the history

  8. add changelog

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    a65eb24 View commit details
    Browse the repository at this point in the history

  9. remove unnecessary field on pluginClient

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    db60f6e View commit details
    Browse the repository at this point in the history

  10. add unit tests to PluginCatalog for secrets/auth plugins

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    151b439 View commit details
    Browse the repository at this point in the history

  11. fix comment

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    fa1aa94 View commit details
    Browse the repository at this point in the history

  12. return pluginClient from TestRunTestPlugin

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    bfdafb8 View commit details
    Browse the repository at this point in the history

  13. add multiplexed backend test

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    e498420 View commit details
    Browse the repository at this point in the history

  14. honor metadatamode value in newbackend pluginconfig

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    53713ad View commit details
    Browse the repository at this point in the history

  15. check that connection exists on cleanup

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    9ae3b45 View commit details
    Browse the repository at this point in the history

  16. add automtls to secrets/auth plugins

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    10a5bdc View commit details
    Browse the repository at this point in the history

  17. don't remove apiclientmeta parsing

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    b55b86a View commit details
    Browse the repository at this point in the history

  18. use formatting directive for fmt.Errorf

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    4f93d8f View commit details
    Browse the repository at this point in the history

  19. fix ut: remove tls provider func

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    b0a2ebf View commit details
    Browse the repository at this point in the history

  20. remove tlsproviderfunc from backend plugin tests

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    d108d0d View commit details
    Browse the repository at this point in the history

  21. use env var to prevent test plugin from running as a unit test

    @fairclothjm
    fairclothjm committed Aug 2, 2022
    Copy the full SHA
    92c4217 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. WIP: remove lazy loading

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    62753b8 View commit details
    Browse the repository at this point in the history

  2. move non lazy loaded backend to new package

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    8c14cc4 View commit details
    Browse the repository at this point in the history

  3. use version wrapper for backend plugin factory

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    3fa3702 View commit details
    Browse the repository at this point in the history

  4. remove backendVersionWrapper type

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    c9a39a6 View commit details
    Browse the repository at this point in the history

  5. implement getBackendPluginType for plugin catalog

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    90b5789 View commit details
    Browse the repository at this point in the history

  6. handle backend plugin v4 registration

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    b4d1202 View commit details
    Browse the repository at this point in the history

  7. add plugin automtls env guard

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    774a6dd View commit details
    Browse the repository at this point in the history

  8. modify plugin factory to determine the backend to use

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    8805c19 View commit details
    Browse the repository at this point in the history

  9. remove old pluginsets from v5 and log pid in plugin catalog

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    18ca49c View commit details
    Browse the repository at this point in the history

  10. add reload mechanism via context

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    493995a View commit details
    Browse the repository at this point in the history

  11. readd v3 and v4 to pluginset

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    9759a0e View commit details
    Browse the repository at this point in the history

  12. call cleanup from reload if non-muxed

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    0c2cde6 View commit details
    Browse the repository at this point in the history

  13. move v5 backend code to new package

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    063f452 View commit details
    Browse the repository at this point in the history

  14. use context reload for for ErrPluginShutdown case

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    1bfeadf View commit details
    Browse the repository at this point in the history

  15. add wrapper on v5 backend

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    dcd3637 View commit details
    Browse the repository at this point in the history

  16. fix run config UTs

    @fairclothjm
    fairclothjm committed Aug 4, 2022
    Copy the full SHA
    0d60783 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. fix unit tests 

    - use v4/v5 mapping for plugin versions
- fix test build err
- add reload method on fakePluginClient
- add multiplexed cases for integration tests
    @fairclothjm
    fairclothjm committed Aug 5, 2022
    Copy the full SHA
    787baeb View commit details
    Browse the repository at this point in the history

  2. remove comment and update AutoMTLS field in test

    @fairclothjm
    fairclothjm committed Aug 5, 2022
    Copy the full SHA
    bce9c30 View commit details
    Browse the repository at this point in the history

  3. remove comment

    @fairclothjm
    fairclothjm committed Aug 5, 2022
    Copy the full SHA
    03e4cdc View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. remove errwrap and unused context

    @fairclothjm
    fairclothjm committed Aug 9, 2022
    Copy the full SHA
    09a5e34 View commit details
    Browse the repository at this point in the history

  2. only support metadatamode false for v5 backend plugins

    @fairclothjm
    fairclothjm committed Aug 9, 2022
    Copy the full SHA
    012ae79 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. update plugin catalog errors

    @fairclothjm
    fairclothjm committed Aug 18, 2022
    Copy the full SHA
    2b92594 View commit details
    Browse the repository at this point in the history

  2. use const for env variables

    @fairclothjm
    fairclothjm committed Aug 18, 2022
    Copy the full SHA
    acf94f7 View commit details
    Browse the repository at this point in the history

  3. rename locks and remove unused

    @fairclothjm
    fairclothjm committed Aug 18, 2022
    Copy the full SHA
    18882ff View commit details
    Browse the repository at this point in the history

  4. remove unneeded nil check

    @fairclothjm
    fairclothjm committed Aug 18, 2022
    Copy the full SHA
    3d3a1e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. improvements based on staticcheck recommendations

    @fairclothjm
    fairclothjm committed Aug 19, 2022
    Copy the full SHA
    3c826e8 View commit details
    Browse the repository at this point in the history

  2. use const for single implementation string

    @fairclothjm
    fairclothjm committed Aug 19, 2022
    Copy the full SHA
    10b2546 View commit details
    Browse the repository at this point in the history

  3. use const for context key

    @fairclothjm
    fairclothjm committed Aug 19, 2022
    Copy the full SHA
    31c3e88 View commit details
    Browse the repository at this point in the history

  4. use info default log level

    @fairclothjm
    fairclothjm committed Aug 19, 2022
    Copy the full SHA
    b32bc62 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. move pid to pluginClient struct

    @fairclothjm
    fairclothjm committed Aug 23, 2022
    Copy the full SHA
    31711be View commit details
    Browse the repository at this point in the history

  2. remove v3 and v4 from multiplexed plugin set

    @fairclothjm
    fairclothjm committed Aug 23, 2022
    Copy the full SHA
    c0b71fa View commit details
    Browse the repository at this point in the history

  3. return from reload when non-multiplexed

    @fairclothjm
    fairclothjm committed Aug 23, 2022
    Copy the full SHA
    70d99f0 View commit details
    Browse the repository at this point in the history

  4. update automtls env string

    @fairclothjm
    fairclothjm committed Aug 23, 2022
    Copy the full SHA
    766f5fe View commit details
    Browse the repository at this point in the history

  5. combine getBackend and getBrokeredClient

    @fairclothjm
    fairclothjm committed Aug 23, 2022
    Copy the full SHA
    3b08d5c View commit details
    Browse the repository at this point in the history

  6. update comments for plugin reload, Backend return val and log

    @fairclothjm
    fairclothjm committed Aug 23, 2022
    Copy the full SHA
    748b676 View commit details
    Browse the repository at this point in the history

  7. revert Backend return type

    @fairclothjm
    fairclothjm committed Aug 23, 2022
    Copy the full SHA
    80b8b11 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into feat/mux-secrets-auth

    @fairclothjm
    fairclothjm committed Aug 23, 2022
    Copy the full SHA
    7f3f47e View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. allow non-muxed plugins to serve v5

    @fairclothjm
    fairclothjm committed Aug 24, 2022
    Copy the full SHA
    86eafcd View commit details
    Browse the repository at this point in the history

  2. move v5 code to existing sdk plugin package

    @fairclothjm
    fairclothjm committed Aug 24, 2022
    Copy the full SHA
    bc2f3e1 View commit details
    Browse the repository at this point in the history

  3. do next export sdk fields now that we have removed extra plugin pkg

    @fairclothjm
    fairclothjm committed Aug 24, 2022
    Copy the full SHA
    4f886f4 View commit details
    Browse the repository at this point in the history

  4. set TLSProvider in ServeMultiplex for backwards compat

    @fairclothjm
    fairclothjm committed Aug 24, 2022
    Copy the full SHA
    3f3b0bf View commit details
    Browse the repository at this point in the history

  5. use bool to flag multiplexing support on grpc backend server

    @fairclothjm
    fairclothjm committed Aug 24, 2022
    Copy the full SHA
    fa40253 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/mux-secrets-auth

    @fairclothjm
    fairclothjm committed Aug 26, 2022
    Copy the full SHA
    dc77bc1 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. revert userpass main.go

    @fairclothjm
    fairclothjm committed Aug 29, 2022
    Copy the full SHA
    4d7dbd1 View commit details
    Browse the repository at this point in the history

  2. refactor plugin sdk 

    - update comments
- make use of multiplexing boolean and single implementation ID const
    @fairclothjm
    fairclothjm committed Aug 29, 2022
    Copy the full SHA
    9431c2d View commit details
    Browse the repository at this point in the history

  3. update comment and use multierr

    @fairclothjm
    fairclothjm committed Aug 29, 2022
    Copy the full SHA
    6afe64e View commit details
    Browse the repository at this point in the history

  4. attempt v4 if dispense fails on getPluginTypeForUnknown

    @fairclothjm
    fairclothjm committed Aug 29, 2022
    Copy the full SHA
    828148e View commit details
    Browse the repository at this point in the history

  5. update comments on sdk plugin backend

    @fairclothjm
    fairclothjm committed Aug 29, 2022
    Copy the full SHA
    fd833f1 View commit details
    Browse the repository at this point in the history