Backport of Fixing excessive unix file permissions into release/1.8.x #14841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-4364/usefully-trusty-starling
branch
from
d09ebca
to
8219da1
Compare
akshya96
reviewed
Apr 1, 2022
| @@ -274,7 +274,7 @@ func EnsurePath(path string, dir bool) error { | |||
| if !dir { | |||
| path = filepath.Dir(path) | |||
| } | |||
| return os.MkdirAll(path, 0o755) | |||
| return os.MkdirAll(path, 0o750) | |||
There was a problem hiding this comment.
I remember seeing this as 0o700 in your main PR. https://github.com/hashicorp/vault/pull/14791/files
There was a problem hiding this comment.
yeah, it seems that backport assistant is not doing the right job. I will push manual backports for all of these.
akshya96
reviewed
Apr 1, 2022
| @@ -86,7 +86,7 @@ func NewBoltSnapshotStore(base string, logger log.Logger, fsm *FSM) (*BoltSnapsh | |||
|
|
|||
| // Ensure our path exists | |||
| path := filepath.Join(base, snapPath) | |||
| if err := os.MkdirAll(path, 0o755); err != nil && !os.IsExist(err) { | |||
| if err := os.MkdirAll(path, 0o750); err != nil && !os.IsExist(err) { | |||
akshya96
reviewed
Apr 1, 2022
| @@ -324,7 +324,7 @@ func (s *BoltSnapshotSink) writeBoltDBFile() error { | |||
| s.logger.Info("creating new snapshot", "path", path) | |||
|
|
|||
| // Make the directory | |||
| if err := os.MkdirAll(path, 0o755); err != nil { | |||
| if err := os.MkdirAll(path, 0o750); err != nil { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14791 to be assessed for backporting due to the inclusion of the label backport/1.8.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
I also ran https://github.com/securego/gosec#github-action