Backport of VAULT-4240 time.After() in a select statement can lead to memory leak into release/1.9.x #14824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/leaky-timeAfter/loudly-cunning-albacore
branch
from
bdacbf1
to
cb325e9
Compare
swayne275
approved these changes
Apr 1, 2022
ccapurso
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14814 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
The below text is copied from the body of the original PR.
The time.After call in the for - select statement can lead to a memory leak because the garbage collector does not cleanup the underlying Timer object until the timer fires. A new timer is initialized at each iteration of the for loop (and hence select), which requires resources. So, many routines originating from the time.After call could lead to overconsumption of the memory.