Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of add value length check to approle createHMAC into release/1.9.x #14764

Merged
merged 3 commits into from Mar 29, 2022
Merged

Backport of add value length check to approle createHMAC into release/1.9.x #14764

merged 3 commits into from Mar 29, 2022

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #14746 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

The below text is copied from the body of the original PR.

Prevent clients from issuing approle login requests with unbounded input requiring SHA256 HMAC calculation by adding a limit check.

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/vault-4245/ultimately-robust-locust branch from 045cf7a to 380447b Compare March 29, 2022 18:44
@vercel vercel bot temporarily deployed to Preview – vault March 29, 2022 18:44 Inactive
@ccapurso ccapurso requested review from a team March 29, 2022 18:47
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 29, 2022 18:56 Inactive
@ccapurso ccapurso merged commit d08649f into release/1.9.x Mar 29, 2022
@ccapurso ccapurso deleted the backport/vault-4245/ultimately-robust-locust branch March 29, 2022 19:50
akshya96 pushed a commit that referenced this pull request Mar 29, 2022
@hc-github-team-secure-vault-core @ccapurso @akshya96
Backport of add value length check to approle createHMAC into release…
326af32 
…/1.9.x (#14764)

* backport of commit e0d23f4

* backport of commit 0fd1e6f

* backport of commit 492b422

Co-authored-by: Chris Capurso <1036769+ccapurso@users.noreply.github.com>
@thiskevinwang thiskevinwang mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

@ccapurso ccapurso Awaiting requested review from ccapurso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hc-github-team-secure-vault-core @ncabatoff @ccapurso