Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKI - Allow performance secondaries to generate and store certificates locally to them #13759

Merged
merged 2 commits into from Jan 24, 2022
Merged

PKI - Allow performance secondaries to generate and store certificates locally to them #13759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bda916b
PKI - Allow performance secondaries to generate and store certificate…
divyapola5 Jan 20, 2022
8c0c310
changelog
sgmiller Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion builtin/logical/pki/path_issue_sign.go
View file
Open in desktop
Expand Up @@ -189,7 +189,8 @@ func (b *backend) pathSignVerbatim(ctx context.Context, req *logical.Request, da

func (b *backend) pathIssueSignCert(ctx context.Context, req *logical.Request, data *framework.FieldData, role *roleEntry, useCSR, useCSRValues bool) (*logical.Response, error) {
// If storing the certificate and on a performance standby, forward this request on to the primary
if !role.NoStore && b.System().ReplicationState().HasState(consts.ReplicationPerformanceStandby|consts.ReplicationPerformanceSecondary) {
// Allow performance secondaries to generate and store certificates locally to them.
if !role.NoStore && b.System().ReplicationState().HasState(consts.ReplicationPerformanceStandby) {
return nil, logical.ErrReadOnly
}

Expand Down
3 changes: 3 additions & 0 deletions changelog/13759.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:bug
secrets/pki: Fix regression causing performance secondaries to forward certificate generation to the primary.
```