Raft/fix raft telemetry metric unit #13749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
approved these changes
Jan 24, 2022
|
Thanks David, can you add a changelog please? See https://github.com/hashicorp/vault/blob/main/CONTRIBUTING.md |
ncabatoff
reviewed
Jan 24, 2022
Updating change description Co-authored-by: Nick Cabatoff <nick.cabatoff@gmail.com>
|
Nice work @davidadeleon! I told you there was nothing to be afraid of! |
This was referenced Jan 24, 2022
joatmon08
pushed a commit
that referenced
this pull request
Jan 25, 2022
Converting raft time metrics to Milliseconds over Default Nanoseconds to maintain consistency
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
Converting raft time metrics to Milliseconds over Default Nanoseconds to maintain consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the Units being reported for the following Telemetry Metrics from Nanoseconds to Milliseconds to match documentation: