Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of auth/ldap: Add username to alias.metadata.name into release/1.9.x #13726

Merged
merged 7 commits into from Jan 20, 2022

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #13669 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

The below text is copied from the body of the original PR.


A change introduced in #11000 introduced a subtle change to entity aliases when upndomain is configured. When using upndomain, the name value in the alias now contains the value stored in upndomain:

{
  "data": {
    "aliases": [
      {
        ...
        "name": "bob@corp.example.net"
      }
    ],
  },
}

This has caused issues in 1.9.x where users are using templated policies and now the UPN domain is being appended. I've added alias.metadata.name which contains the raw username without UPN domain.

"aliases": [
  {
    "canonical_id": "c05d6c0a-8d0b-f10b-ab9a-26bb09abf821",
    "creation_time": "2022-01-14T22:00:51.8852898Z",
    "custom_metadata": null,
    "id": "290f51a7-14d9-8488-c344-20ce7b159fd5",
    "last_update_time": "2022-01-14T22:00:51.8852898Z",
    "local": false,
    "merged_from_canonical_ids": null,
    "metadata": {
      "name": "bob"
    },
    "mount_accessor": "auth_ldap_6e553280",
    "mount_path": "auth/ldap/",
    "mount_type": "ldap",
    "name": "bob@corp.example.net"
  }

@jasonodonnell jasonodonnell merged commit ffa1f54 into release/1.9.x Jan 20, 2022
@jasonodonnell jasonodonnell deleted the backport/ldap-alias/admittedly-fit-tapir branch January 20, 2022 18:08
akshya96 pushed a commit that referenced this pull request Jan 20, 2022
…se/1.9.x (#13726)

* backport of commit 5dc6e43

* backport of commit 002ed5f

* backport of commit 77e4dfe

* backport of commit 6514151

* backport of commit eb7cee2

* backport of commit 7dc5acc

* backport of commit 9ae01d7

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
@kalafut kalafut added this to the 1.9.3 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants