Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oidc: check for nil signing key on rotation #13716

Merged
merged 4 commits into from Jan 24, 2022
Merged

oidc: check for nil signing key on rotation #13716

merged 4 commits into from Jan 24, 2022

Commits on Jan 19, 2022

  1. check for nil signing key on rotation

    @fairclothjm
    fairclothjm committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    f0fc03e View commit details
    Browse the repository at this point in the history

  2. add changelog

    @fairclothjm
    fairclothjm committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    9a9eba6 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Update nil signing key handling 

    - bypass setting ExpireAt if signing key is nil in rotate
- return err if singing key is nil in signPayload
    @fairclothjm
    fairclothjm committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    7fc38ac View commit details
    Browse the repository at this point in the history

  2. add comment; update error msg on signPayload; refactor UT

    @fairclothjm
    fairclothjm committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    eaf572e View commit details
    Browse the repository at this point in the history