Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Update mssql's contained_db field to accept a boolean into release/1.9.x #13711

Merged
merged 2 commits into from Jan 19, 2022
Merged

Backport of Update mssql's contained_db field to accept a boolean into release/1.9.x #13711

merged 2 commits into from Jan 19, 2022

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #13469 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

The below text is copied from the body of the original PR.

Previously the contained_db parameter would only accept a string value
despite the fact that field type is documented as a boolean.

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/VAULT-4404/mssql-fix-contained_db-parsing/factually-evident-caribou branch from 6c3fa34 to 099def5 Compare January 19, 2022 19:18
@vercel vercel bot temporarily deployed to Preview – vault-storybook January 19, 2022 19:18 Inactive
@benashz benashz merged commit 9f2f924 into release/1.9.x Jan 19, 2022
@benashz benashz deleted the backport/VAULT-4404/mssql-fix-contained_db-parsing/factually-evident-caribou branch January 19, 2022 20:25
akshya96 pushed a commit that referenced this pull request Jan 20, 2022
@hc-github-team-secure-vault-core @benashz @akshya96
Backport of Update mssql's contained_db field to accept a boolean int…
97607c2 
…o release/1.9.x (#13711)

* backport of commit 5bb6996

* backport of commit 04d8730

Co-authored-by: Ben Ash <bash@hashicorp.com>
@benashz benashz added this to the 1.9.3 milestone Jan 24, 2022
@thiskevinwang thiskevinwang mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

@benashz benashz Awaiting requested review from benashz

@tomhjp tomhjp Awaiting requested review from tomhjp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hc-github-team-secure-vault-core @vinay-gopalan @benashz