Backport of Support clearing an identity alias' custom_metadata into release/1.9.x #13704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/VAULT-4074/identity-alias-clear-custom-metadata/primarily-bright-lionfish
branch
from
5debdfa
to
7e1c191
Compare
tomhjp
reviewed
Jan 19, 2022
| if err != nil { | ||
| return nil, err | ||
| } | ||
| customMetadata = data.(map[string]string) |
There was a problem hiding this comment.
Could a client craft a request that causes a panic if they set custom_metadata to something that's not a map[string]string?
There was a problem hiding this comment.
This is not my PR, but I reviewed the original prior to the backport. This type assertion should be safe due to the GetOk call above. The custom_metadata field is defined as framework.TypeKVPairs which is ultimately parsed as map[string]string.
There was a problem hiding this comment.
Thanks for the explainer! TIL
ccapurso
approved these changes
Jan 19, 2022
tomhjp
approved these changes
Jan 19, 2022
| if err != nil { | ||
| return nil, err | ||
| } | ||
| customMetadata = data.(map[string]string) |
There was a problem hiding this comment.
Thanks for the explainer! TIL
…clear-custom-metadata/primarily-bright-lionfish
benashz
deleted the
backport/VAULT-4074/identity-alias-clear-custom-metadata/primarily-bright-lionfish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #13395 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
The below text is copied from the body of the original PR.
Previously, an update to an entity alias supports updating the
custom_metadata as long as the update is not empty, which makes it
impossible to clear the metadata values completely.
Fixes: