Support go-sockaddr templates in top-level cluster_addr config #13678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly used, or at least isn't as important as the top-level clusteraddr setting. As such, go-sockaddr templating needs to be implemented for the top-level `cluster_addr` setting or it's unusable for HA. Also fix a nil pointer panic I discovered at the same time.
raskchanky
approved these changes
Jan 18, 2022
ncabatoff
added
backport/1.9.x
backport/website-deprecated
ncabatoff
added a commit
that referenced
this pull request
Jan 19, 2022
In doing some testing I found that the listener clusteraddr isn't really used, or at least isn't as important as the top-level clusteraddr setting. As such, go-sockaddr templating needs to be implemented for the top-level `cluster_addr` setting or it's unusable for HA. Also fix a nil pointer panic I discovered at the same time.
ncabatoff
added a commit
that referenced
this pull request
Jan 20, 2022
… (#13706) In doing some testing I found that the listener clusteraddr isn't really used, or at least isn't as important as the top-level clusteraddr setting. As such, go-sockaddr templating needs to be implemented for the top-level `cluster_addr` setting or it's unusable for HA. Also fix a nil pointer panic I discovered at the same time.
akshya96
pushed a commit
that referenced
this pull request
Jan 20, 2022
… (#13706) In doing some testing I found that the listener clusteraddr isn't really used, or at least isn't as important as the top-level clusteraddr setting. As such, go-sockaddr templating needs to be implemented for the top-level `cluster_addr` setting or it's unusable for HA. Also fix a nil pointer panic I discovered at the same time.
joatmon08
pushed a commit
that referenced
this pull request
Jan 25, 2022
In doing some testing I found that the listener clusteraddr isn't really used, or at least isn't as important as the top-level clusteraddr setting. As such, go-sockaddr templating needs to be implemented for the top-level `cluster_addr` setting or it's unusable for HA. Also fix a nil pointer panic I discovered at the same time.
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
…corp#13678) In doing some testing I found that the listener clusteraddr isn't really used, or at least isn't as important as the top-level clusteraddr setting. As such, go-sockaddr templating needs to be implemented for the top-level `cluster_addr` setting or it's unusable for HA. Also fix a nil pointer panic I discovered at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In doing some testing I found that the listener clusteraddr isn't really used, or at least isn't as important as the top-level clusteraddr setting. As such, go-sockaddr templating needs to be implemented for the top-level
cluster_addrsetting or it's unusable for HA.Also fix a nil pointer panic I discovered at the same time.