Backport of Vault-3991 Code Scanning Alerts Changes into release/1.9.x #13670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ncabatoff
approved these changes
Jan 18, 2022
akshya96
force-pushed
the
backport/vault3991CodeScanningAlerts/trivially-glad-guppy
branch
from
17789d3
to
62b9bf6
Compare
hc-github-team-secure-vault-core
requested a review
from taoism4504
as a code owner
akshya96
force-pushed
the
backport/vault3991CodeScanningAlerts/trivially-glad-guppy
branch
from
62b9bf6
to
45149f8
Compare
…s/trivially-glad-guppy
ncabatoff
reviewed
Jan 21, 2022
command/base_flags.go
Outdated
| @@ -10,6 +10,7 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| "github.com/hashicorp/vault/sdk/helper/consts" | |||
There was a problem hiding this comment.
For 1.9 we should be using math.MaxInt, it's built with Go 1.17
…s/trivially-glad-guppy
…s/trivially-glad-guppy
…s/trivially-glad-guppy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #13667 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Fixes code scanning alerts